Re: [PATCH net-next 1/3] net_sched: act: Dont increment refcnt on replace

Re: [PATCH net-next 1/3] net_sched: act: Dont increment refcnt on replace

[Cong Wang]

On Mon, Dec 23, 2013 at 5:02 AM, Jamal Hadi Salim <jhs@mojatatu.com> wrote:
>  This is a bug fix. The existing code tries to kill many
>  birds with one stone: Handling binding of actions to
>  filters, new actions and replacing of action
>  attributes. A simple test case to illustrate:

Therefore should go to net rather than net-next?

Re: [PATCH net-next 1/3] net_sched: act: Dont increment refcnt on replace

[Jamal Hadi Salim]

On 12/23/13 19:41, Cong Wang wrote:

>
> Therefore should go to net rather than net-next?
>

I asked that question to Dave. Will let him call it.
This one sits on patches that are on top of net-next.

cheers,
jamal

Re: [PATCH net-next 1/3] net_sched: act: Dont increment refcnt on replace

[David Miller]

From: Jamal Hadi Salim <jhs@mojatatu.com>
Date: Mon, 23 Dec 2013 08:02:11 -0500

>  This is a bug fix. The existing code tries to kill many
>  birds with one stone: Handling binding of actions to
>  filters, new actions and replacing of action
>  attributes. A simple test case to illustrate:
> 
> XXXX
>  moja@fe1:~$ sudo tc actions add action drop index 12
>  moja@fe1:~$ actions get action gact index 12        
>  action order 1: gact action drop
>   random type none pass val 0 
>   index 12 ref 1 bind 0
>  moja@fe1:~$ sudo tc actions replace action ok index 12
>  moja@fe1:~$ actions get action gact index 12        
>  action order 1: gact action drop
>   random type none pass val 0 
>   index 12 ref 2 bind 0
> XXXX
> 
> The above shows the refcounf being wrongly incremented on replace.
> There are more complex scenarios with binding of actions to filters
> that i am leaving out that didnt work as well...
> 
> Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>

Applied to 'net', thanks.

Re: [PATCH net-next 0/3] net_sched: act: Various fixes

[Jamal Hadi Salim]

Dave,

Patches 2 + 3 are missing (from both tree and patchwork).

cheers,
jamal

On 12/23/13 08:02, Jamal Hadi Salim wrote:
> The first and last are bug fixes. The second one is a code improvement
>
> Jamal Hadi Salim (3):
>    Dont increment refcnt on replace
>    Remove unnecessary checks for act->ops
>    action flushing missaccounting
>
>   net/sched/act_api.c     |   51 +++++++++++++++++------------------------------
>   net/sched/act_csum.c    |   10 +++++-----
>   net/sched/act_gact.c    |    7 ++++---
>   net/sched/act_ipt.c     |    8 +++++---
>   net/sched/act_nat.c     |   10 +++++-----
>   net/sched/act_pedit.c   |    8 +++++---
>   net/sched/act_police.c  |    4 +++-
>   net/sched/act_simple.c  |    9 ++++++---
>   net/sched/act_skbedit.c |    7 ++++---
>   net/sched/cls_api.c     |    2 +-
>   10 files changed, 56 insertions(+), 60 deletions(-)
>

Re: [PATCH net-next 0/3] net_sched: act: Various fixes

[David Miller]

From: Jamal Hadi Salim <jhs@mojatatu.com>
Date: Fri, 03 Jan 2014 07:24:54 -0500

> Patches 2 + 3 are missing (from both tree and patchwork).

I'll take a look.

Re: [PATCH net-next 2/3] Remove unnecessary checks for act->ops

[David Miller]

From: Jamal Hadi Salim <jhs@mojatatu.com>
Date: Mon, 23 Dec 2013 08:02:12 -0500

> Remove unnecessary checks for act->ops
> (suggested by Eric Dumazet).
> 
> Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>

Applied.

Re: [Patch net-next 3/3] net_sched: act: action flushing missaccounting

[David Miller]

From: Jamal Hadi Salim <jhs@mojatatu.com>
Date: Mon, 23 Dec 2013 08:02:13 -0500

> action flushing missaccounting
> Account only for deleted actions
> 
> Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>

Applied.