From: "H. Peter Anvin" <hpa@zytor.com>
To: "H.J. Lu" <hjl.tools@gmail.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Use __kernel_long_t in struct mq_attr
Date: Thu, 26 Dec 2013 09:53:14 -0800 [thread overview]
Message-ID: <52BC6D0A.8060407@zytor.com> (raw)
In-Reply-To: <20131226155410.GH23355@gmail.com>
On 12/26/2013 07:54 AM, H.J. Lu wrote:
> On Wed, Dec 25, 2013 at 08:58:34AM -0800, H.J. Lu wrote:
>> Both x32 and x86-64 use the same struct mq_attr for system calls. But
>> x32 long is 32-bit. This patch replaces long with __kernel_long_t in
>> struct mq_attr.
>>
>
> Here is the updated patch which uses __kernel_long_t only if
> __BITS_PER_LONG == 64.
>
That seems wrong in multiple ways... not only does it add more clutter,
but it would seem to give the wrong types when __BITS_PER_LONG in
userspace is 32.
-hpa
next prev parent reply other threads:[~2013-12-26 17:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-25 16:58 [PATCH] Use __kernel_long_t in struct mq_attr H.J. Lu
2013-12-26 15:54 ` H.J. Lu
2013-12-26 17:53 ` H. Peter Anvin [this message]
2013-12-26 17:59 ` H.J. Lu
2013-12-26 18:03 ` H. Peter Anvin
2013-12-26 18:10 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52BC6D0A.8060407@zytor.com \
--to=hpa@zytor.com \
--cc=hjl.tools@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.