From: Josh Durgin <josh.durgin@inktank.com>
To: Ilya Dryomov <ilya.dryomov@inktank.com>, ceph-devel@vger.kernel.org
Subject: Re: [PATCH 0/2] rbd: tear down watch request if rbd_dev_device_setup() fails
Date: Thu, 26 Dec 2013 12:34:36 -0800 [thread overview]
Message-ID: <52BC92DC.6010807@inktank.com> (raw)
In-Reply-To: <1387224335-902-1-git-send-email-ilya.dryomov@inktank.com>
On 12/16/2013 12:05 PM, Ilya Dryomov wrote:
> Hello,
>
> Currently, if rbd_dev_device_setup() fails, we don't tear down our
> watch request. Looks like this bug was introduced by 1f3ef78861ac,
> which moved a tear down call while fixing something else. Fix it.
>
> These patches can be pulled from wip-rbd-unwatch branch of
> ceph-client.git.
>
> Thanks,
>
> Ilya
>
>
> Ilya Dryomov (2):
> rbd: introduce rbd_dev_header_unwatch_sync() and switch to it
> rbd: tear down watch request if rbd_dev_device_setup() fails
>
> drivers/block/rbd.c | 41 ++++++++++++++++++++++++++++-------------
> 1 file changed, 28 insertions(+), 13 deletions(-)
>
These look good to me.
Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
prev parent reply other threads:[~2013-12-26 20:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-16 20:05 [PATCH 0/2] rbd: tear down watch request if rbd_dev_device_setup() fails Ilya Dryomov
2013-12-16 20:05 ` [PATCH 1/2] rbd: introduce rbd_dev_header_unwatch_sync() and switch to it Ilya Dryomov
2013-12-16 20:05 ` [PATCH 2/2] rbd: tear down watch request if rbd_dev_device_setup() fails Ilya Dryomov
2013-12-26 20:34 ` Josh Durgin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52BC92DC.6010807@inktank.com \
--to=josh.durgin@inktank.com \
--cc=ceph-devel@vger.kernel.org \
--cc=ilya.dryomov@inktank.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.