From: Wang Weidong <wangweidong1@huawei.com>
To: David Miller <davem@davemloft.net>
Cc: <jon.maloy@ericsson.com>, <allan.stephens@windriver.com>,
<David.Laight@ACULAB.COM>, <netdev@vger.kernel.org>,
<sergei.shtylyov@cogentembedded.com>, <ying.xue@windriver.com>
Subject: Re: [PATCH net-next RESEND v3] tipc: make the code look more readable
Date: Fri, 27 Dec 2013 12:21:04 +0800 [thread overview]
Message-ID: <52BD0030.10107@huawei.com> (raw)
In-Reply-To: <20131226.230438.1160354521580370981.davem@davemloft.net>
On 2013/12/27 12:04, David Miller wrote:
>
> You need to resubmit patch #1 along with this one, not just this
> one by itself.
>
> Thanks.
>
>
As Ying pointed out that the patch #1 ("tipc: make the code look more better")
does not provide any value. something like below:
Actually the original logic seems better understandable for us because
it immediately lets us know how to do if "tp_ptr->connected" is true.
Instead the patch has a little negative effect on performance because
"tp_ptr->connected" is true in most time.
So I drop the patch #1. Now only this patch.
Regards,
Wang
next prev parent reply other threads:[~2013-12-27 4:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 7:03 [PATCH net-next 0/2] tipc: do some fixups Wang Weidong
2013-12-17 7:03 ` [PATCH net-next 1/2] tipc: make the code look more better Wang Weidong
2013-12-17 7:03 ` [PATCH net-next 2/2] tipc: make the code look more readability Wang Weidong
2013-12-27 1:45 ` [PATCH net-next v3 2/2] tipc: make the code look more readable Wang Weidong
2013-12-27 1:51 ` Ying Xue
2013-12-27 1:59 ` Wang Weidong
2013-12-27 4:04 ` David Miller
2013-12-27 2:09 ` [PATCH net-next RESEND v3] " Wang Weidong
2013-12-27 4:04 ` David Miller
2013-12-27 4:21 ` Wang Weidong [this message]
2013-12-24 22:45 ` [PATCH net-next 0/2] tipc: do some fixups David Miller
2013-12-25 1:33 ` Wang Weidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52BD0030.10107@huawei.com \
--to=wangweidong1@huawei.com \
--cc=David.Laight@ACULAB.COM \
--cc=allan.stephens@windriver.com \
--cc=davem@davemloft.net \
--cc=jon.maloy@ericsson.com \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.