From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: David Miller <davem@davemloft.net>, f.fainelli@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] phy: IRQ cannot be shared
Date: Fri, 27 Dec 2013 22:53:40 +0300 [thread overview]
Message-ID: <52BDDAC4.2050100@cogentembedded.com> (raw)
In-Reply-To: <20131227.134333.1370704464169101441.davem@davemloft.net>
On 12/27/2013 09:43 PM, David Miller wrote:
>>> With the way PHY IRQ handler is implemented (all real handling being pushed to
>>> the workqueue and returning IRQ_HANDLED all the time PHY is active), we cannot
>>> really claim that PHY IRQ can be shared when calling request_irq().
>> Looks good, in the future we might want to be able to let the Ethernet
>> MAC driver specify the flags to pass down to request_irq()
I don't think this is such a good idea now since the way to pass those
flags would be quite clumsy (like it is for IRQs, via array of 32 entries).
I'd prefer irq_set_irq_type() if there'd be no objections.
>> but this is
>> good enough for me for the time being.
>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
> I really worry that putting this new restriction in place is going to
> break a bunch of drivers.
> Arguably they are broken,
Yes, they already are.
> but they are least mostly working right now
> and probes will completely fail after this change.
I don't see how the probes will fail. Have you seen the surrounding code?
It should just switch to PHY polling if request_irq() fails and return 0. Am I
missing something?
> Feel free to allay my concerns, but tossing this into 'net' and
> -stable with such a possible risk really concerns me.
Up to you, of course.
WBR, Sergei
next prev parent reply other threads:[~2013-12-27 18:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 19:09 [PATCH] phy: IRQ cannot be shared Sergei Shtylyov
2013-12-20 18:24 ` Florian Fainelli
2013-12-27 18:43 ` David Miller
2013-12-27 19:53 ` Sergei Shtylyov [this message]
2013-12-30 3:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52BDDAC4.2050100@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.