From: Daniel Borkmann <dborkman@redhat.com>
To: Li Zefan <lizefan@huawei.com>
Cc: pablo@netfilter.org, netfilter-devel@vger.kernel.org,
Tejun Heo <tj@kernel.org>,
cgroups@vger.kernel.org
Subject: Re: [PATCH nf-next v3] netfilter: xtables: lightweight process control group matching
Date: Sat, 28 Dec 2013 09:17:58 +0100 [thread overview]
Message-ID: <52BE8936.6000001@redhat.com> (raw)
In-Reply-To: <52BE2A79.6040504@huawei.com>
On 12/28/2013 02:33 AM, Li Zefan wrote:
> On 2013/12/27 16:05, Daniel Borkmann wrote:
>> On 12/27/2013 04:13 AM, Li Zefan wrote:
...
>>> I'd suggest splitting cls_cgroup code into 2 parts. The first part
>>> is to manage cgroupfs and classid, and should be put into net/core/
>>> and add a new config like NET_CGROUP_CLASSID for it. The second part
>>> is specific cls_cgroup code.
>>
>> Sure, if this is wished, I'd do this as a follow-up as it doesn't affect
>> any of this code in netfilter here.
>
> We should clean up the code before introducing a new feature, not the
> other way.
Hehe, quite honestly, I think this is YOUR opinion of a "cleanup", which
makes the code actually more complicated, and it's not strictly needed.
If you are so desperate about this separation, fine, I will do this, but
again, I don't think it's *strictly* required for this.
next prev parent reply other threads:[~2013-12-28 8:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1387815795.git.dborkman@redhat.com>
[not found] ` <cover.1387815795.git.dborkman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-12-23 17:41 ` [PATCH nf-next v3] netfilter: xtables: lightweight process control group matching Daniel Borkmann
2013-12-27 3:13 ` Li Zefan
2013-12-27 3:13 ` Li Zefan
[not found] ` <52BCF04B.3070908-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-12-27 8:05 ` Daniel Borkmann
[not found] ` <52BD34D1.1040708-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-12-28 1:33 ` Li Zefan
2013-12-28 1:33 ` Li Zefan
2013-12-28 8:17 ` Daniel Borkmann [this message]
[not found] ` <52BE8936.6000001-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-12-28 8:44 ` Daniel Borkmann
[not found] ` <52BE8F50.4080005-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-12-28 9:20 ` Li Zefan
2013-12-28 9:20 ` Li Zefan
[not found] ` <52BE97DC.5090807-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-12-28 9:54 ` Li Zefan
2013-12-28 9:54 ` Li Zefan
2013-12-28 18:04 ` Daniel Borkmann
2013-12-28 18:37 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52BE8936.6000001@redhat.com \
--to=dborkman@redhat.com \
--cc=cgroups@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.