All of lore.kernel.org
 help / color / mirror / Atom feed
From: Prarit Bhargava <prarit@redhat.com>
To: "H. Peter Anvin" <hpa@linux.intel.com>
Cc: linux-kernel@vger.kernel.org,
	Michel Lespinasse <walken@google.com>,
	Seiji Aguchi <seiji.aguchi@hds.com>,
	Yang Zhang <yang.z.zhang@Intel.com>,
	Paul Gortmaker <paul.gortmaker@windriver.com>,
	Janet Morgan <janet.morgan@Intel.com>,
	Tony Luck <tony.luck@Intel.com>, Ruiv Wang <ruiv.wang@gmail.com>,
	Andi Kleen <ak@linux.intel.com>,
	x86@kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] x86, irq, fix logical AND/OR error in check_irq_vectors_for_cpu_disable()
Date: Sat, 28 Dec 2013 10:58:54 -0500	[thread overview]
Message-ID: <52BEF53E.4000704@redhat.com> (raw)
In-Reply-To: <52BE244B.5040206@linux.intel.com>



On 12/27/2013 08:07 PM, H. Peter Anvin wrote:
> On 12/27/2013 08:13 AM, Prarit Bhargava wrote:
>>>
>>> Back to my question, assume cpu1 will be off-lined and one irq affinity is
>>> set as (1, 2) -- this irq will be bypassed. Looks good. But if one irq
>>> affinity is set as only (1), -- this irq is bypassed, too. Not right!
>>
>> Oh, yes, this is a bug.  ... and as you point out ...
>>
> 
> Does this mean the patch that is currently in my tree should not be
> pushed to Linus?  It sounds like that to me...

Yes, hpa -- please drop the patch.  I will resubmit an updated patch after testing.

P.

> 
> 	-hpa
> 

  reply	other threads:[~2013-12-28 15:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-23 14:39 [PATCH] x86, irq, fix logical AND/OR error in check_irq_vectors_for_cpu_disable() Prarit Bhargava
2013-12-24  2:51 ` Chen, Gong
2013-12-24 13:19   ` Prarit Bhargava
2013-12-25  2:40     ` Chen, Gong
2013-12-27 16:13       ` Prarit Bhargava
2013-12-28  1:07         ` H. Peter Anvin
2013-12-28 15:58           ` Prarit Bhargava [this message]
2013-12-27 22:01 ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52BEF53E.4000704@redhat.com \
    --to=prarit@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=hpa@linux.intel.com \
    --cc=janet.morgan@Intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=ruiv.wang@gmail.com \
    --cc=seiji.aguchi@hds.com \
    --cc=stable@vger.kernel.org \
    --cc=tony.luck@Intel.com \
    --cc=walken@google.com \
    --cc=x86@kernel.org \
    --cc=yang.z.zhang@Intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.