All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hartmut Knaack <knaack.h@gmx.de>
To: linux-iio@vger.kernel.org
Subject: [PATCH]staging:iio:ad799x make use of platform_data optional
Date: Sun, 29 Dec 2013 12:49:11 +0100	[thread overview]
Message-ID: <52C00C37.2080009@gmx.de> (raw)

Setting Vref with platform_data is a neat feature, though it is not essential
for operating these devices. So make the use of platform_data optional and set
default value of 1000 mV if nothing else is defined.

Signed-off-by: Hartmut Knaack <knaack.h@gmx.de>
---
diff --git a/drivers/staging/iio/adc/ad799x_core.c b/drivers/staging/iio/adc/ad799x_core.c
index 9428be8..e32a555 100644
--- a/drivers/staging/iio/adc/ad799x_core.c
+++ b/drivers/staging/iio/adc/ad799x_core.c
@@ -545,10 +545,12 @@ static int ad799x_probe(struct i2c_client *client,
 
 	/* TODO: Add pdata options for filtering and bit delay */
 
-	if (!pdata)
-		return -EINVAL;
-
-	st->int_vref_mv = pdata->vref_mv;
+	if ((!pdata) || (!pdata->vref_mv)) {
+		dev_warn(&client->dev,
+			 "No platform data found, setting Vref to 1000 mV\n");
+		st->int_vref_mv = 1000;
+	} else
+		st->int_vref_mv = pdata->vref_mv;
 
 	st->reg = devm_regulator_get(&client->dev, "vcc");
 	if (!IS_ERR(st->reg)) {

             reply	other threads:[~2013-12-29 11:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-29 11:49 Hartmut Knaack [this message]
2014-01-01 12:55 ` [PATCH]staging:iio:ad799x make use of platform_data optional Jonathan Cameron
2014-01-01 13:17   ` Hartmut Knaack
2014-01-01 14:14     ` Jonathan Cameron
2014-01-01 15:37       ` Lars-Peter Clausen
2014-01-01 23:19         ` Hartmut Knaack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52C00C37.2080009@gmx.de \
    --to=knaack.h@gmx.de \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.