From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49304)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <loic@dachary.org>) id 1VxR3d-0003E8-2P
	for qemu-devel@nongnu.org; Sun, 29 Dec 2013 19:50:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <loic@dachary.org>) id 1VxR3Y-0000Z5-3W
	for qemu-devel@nongnu.org; Sun, 29 Dec 2013 19:50:12 -0500
Received: from smtp.dmail.dachary.org ([91.121.254.229]:39077)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <loic@dachary.org>) id 1VxR3X-0000Yi-T9
	for qemu-devel@nongnu.org; Sun, 29 Dec 2013 19:50:08 -0500
Message-ID: <52C0C33E.2070603@dachary.org>
Date: Mon, 30 Dec 2013 01:50:06 +0100
From: Loic Dachary <loic@dachary.org>
MIME-Version: 1.0
References: <1388363614-25411-1-git-send-email-loic@dachary.org>
	<20131230003919.GA3032@irqsave.net>
In-Reply-To: <20131230003919.GA3032@irqsave.net>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="LquUSB8rm22sIkb0G8db09bpQJs33aPfE"
Subject: Re: [Qemu-devel] [PATCH] discard rbd error output when not relevant
 in qemu-iotests
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-1?Q?Beno=EEt_Canet?= <benoit.canet@irqsave.net>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--LquUSB8rm22sIkb0G8db09bpQJs33aPfE
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Hi Beno=EEt,

If I understand correctly common.filter is designed to transform the outp=
ut and remove variance. In the case of rbd displaying the progress of rem=
oval, it is something we probably want to get rid of entirely. Please let=
 me know if I'm missing something and I'll update the patch according to =
your suggestion.

Cheers

On 30/12/2013 01:39, Beno=EEt Canet wrote:
> Le Monday 30 Dec 2013 =E0 01:33:34 (+0100), Loic Dachary a =E9crit :
>> Stash the rbd stderr and stdout because it also contains human readabl=
e
>> progress messages : Removing image: 3% complete... in addition to
>> potential error messages.
>>
>> Display the stashed output if rbd exits on error.
>>
>> Signed-off-by: Loic Dachary <loic@dachary.org>
>> ---
>>  tests/qemu-iotests/common.rc | 6 +++++-
>>  1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.=
rc
>> index 28ba0d9..af66bbd 100644
>> --- a/tests/qemu-iotests/common.rc
>> +++ b/tests/qemu-iotests/common.rc
>> @@ -189,7 +189,11 @@ _cleanup_test_img()
>>              ;;
>> =20
>>          rbd)
>> -            rbd rm "$TEST_DIR/t.$IMGFMT" > /dev/null
>> +            if ! rbd rm "$TEST_DIR/t.$IMGFMT" > $TEST_DIR/rbd.out 2>&=
1
>> +            then
>> +                cat $TEST_DIR/rbd.out
>> +            fi
>> +            rm $TEST_DIR/rbd.out
>>              ;;
>> =20
>>          sheepdog)
>=20
> Hi Lo=EFc,
>=20
> Maybe you could filter by modifying _filter_qemu_io.
>=20
> Best regards
>=20
> Beno=EEt
>> --=20
>> 1.8.3.2
>>
>>
>=20
>=20
>=20

--=20
Lo=EFc Dachary, Artisan Logiciel Libre


--LquUSB8rm22sIkb0G8db09bpQJs33aPfE
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlLAwz4ACgkQ8dLMyEl6F20w1ACfeaQ/1c11s+fSBbGtWR6yUnIw
GTcAoKMozrN334WdLiQOPyQoFxJfL6Hm
=li4i
-----END PGP SIGNATURE-----

--LquUSB8rm22sIkb0G8db09bpQJs33aPfE--