From: Ding Tianhong <dingtianhong@huawei.com>
To: Joe Perches <joe@perches.com>, Ding Tianhong <dthxman@gmail.com>
Cc: Dmitry Tarnyagin <dmitry.tarnyagin@lockless.no>,
"David S. Miller" <davem@davemloft.net>,
Netdev <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v2 20/20] net: caif: slight optimization of addr compare
Date: Mon, 30 Dec 2013 10:14:15 +0800 [thread overview]
Message-ID: <52C0D6F7.2020301@huawei.com> (raw)
In-Reply-To: <1388250271.24123.4.camel@joe-AO722>
On 2013/12/29 1:04, Joe Perches wrote:
> On Sat, 2013-12-28 at 23:02 +0800, Ding Tianhong wrote:
>> 于 2013/12/28 14:59, Joe Perches 写道:
>>> On Sat, 2013-12-28 at 14:18 +0800, Ding Tianhong wrote:
>>>> Use possibly more efficient ether_addr_equal
>>>> to instead of memcmp.
>>>
>>> This may be a distinction without difference, but
>>> is a CAIF seghead also an ethernet address?
>>>
>> NO，this is a coincidence, the CAIF seghead is 6 bytes too,
>> So from a logical point of view, maybe a new function with
>> suitable name will be more reasonable here, but the name of
>> ether_addr_equal is not correctly here.:)
>
> So please remove this one from the series.
>
>
Yes, Ok!
Regards
Ding
>
>
prev parent reply other threads:[~2013-12-30 2:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-28 6:18 [PATCH net-next v2 20/20] net: caif: slight optimization of addr compare Ding Tianhong
2013-12-28 6:59 ` Joe Perches
2013-12-28 15:02 ` Ding Tianhong
2013-12-28 17:04 ` Joe Perches
2013-12-30 2:14 ` Ding Tianhong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52C0D6F7.2020301@huawei.com \
--to=dingtianhong@huawei.com \
--cc=davem@davemloft.net \
--cc=dmitry.tarnyagin@lockless.no \
--cc=dthxman@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.