Re: [PATCH] grub-core/term/efi/console.c: Use EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL if available

["Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 759 bytes --]

On 29.12.2013 08:04, Josh Triplett wrote:
> +  term->data = grub_efi_locate_protocol(&simple_text_input_ex_guid, NULL);
This will find the first handle that provides
EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL, not necessarily the same as normal
console and you may inadvertently switch to another console. You have to
look for protocols on input handle.

> +      if (shift_state & (GRUB_EFI_RIGHT_SHIFT_PRESSED |
GRUB_EFI_LEFT_SHIFT_PRESSED))
> +	result |= GRUB_TERM_SHIFT;
The keys which have natural meaning for shifted version never should
receive GRUB_TERM_SHIFT. E.g. Shift+d should give 'D', not
'd'|GRUB_TERM_SHIFT.
Easiest way is to add GRUB_TERM_SHIFT only if GRUB_TERM_EXTENDED is
already present.
What about providing keystatus function?


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 291 bytes --]