From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58675) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VxXcG-0005UL-7d for qemu-devel@nongnu.org; Mon, 30 Dec 2013 02:50:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VxXcB-0000B8-76 for qemu-devel@nongnu.org; Mon, 30 Dec 2013 02:50:24 -0500 Received: from [2a03:4000:1::4e2f:c7ac:d] (port=47742 helo=v220110690675601.yourvserver.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VxXcB-0000B2-0E for qemu-devel@nongnu.org; Mon, 30 Dec 2013 02:50:19 -0500 Message-ID: <52C125A6.5030804@weilnetz.de> Date: Mon, 30 Dec 2013 08:49:58 +0100 From: Stefan Weil MIME-Version: 1.0 References: <1388382585-30853-1-git-send-email-hutao@cn.fujitsu.com> In-Reply-To: <1388382585-30853-1-git-send-email-hutao@cn.fujitsu.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] docs/specs/qcow2.txt: fix incorrect bits of offsets in entries List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hu Tao , qemu-devel@nongnu.org Am 30.12.2013 06:49, schrieb Hu Tao: > Fix incorrect bits of offsets in refcount table entry, l1 table > entry and l2 table entry. See REFT_OFFSET_MASK, L1E_OFFSET_MASK > and L2E_OFFSET_MASK. > > Fix a typo while at the file. > > Signed-off-by: Hu Tao > --- > docs/specs/qcow2.txt | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/docs/specs/qcow2.txt b/docs/specs/qcow2.txt > index f19536a..408f93f 100644 > --- a/docs/specs/qcow2.txt > +++ b/docs/specs/qcow2.txt > @@ -192,9 +192,9 @@ as follows: > > Refcount table entry: > > - Bit 0 - 8: Reserved (set to 0) > + Bit 0 - 7: Reserved (set to 0) > > - 9 - 63: Bits 9-63 of the offset into the image file at which the > + 8 - 63: Bits 9-63 of the offset into the image file at which the What about the comment? Does it need a change, too? > refcount block starts. Must be aligned to a cluster > boundary. > > @@ -218,7 +218,7 @@ The L1 table has a variable size (stored in the header) and may use multiple > clusters, however it must be contiguous in the image file. L2 tables are > exactly one cluster in size. > > -Given a offset into the virtual disk, the offset into the image file can be > +Given an offset into the virtual disk, the offset into the image file can be > obtained as follows: > > l2_entries = (cluster_size / sizeof(uint64_t)) > @@ -233,9 +233,9 @@ obtained as follows: > > L1 table entry: > > - Bit 0 - 8: Reserved (set to 0) > + Bit 0 - 7: Reserved (set to 0) > > - 9 - 55: Bits 9-55 of the offset into the image file at which the L2 > + 8 - 55: Bits 9-55 of the offset into the image file at which the L2 Change comment, too? > table starts. Must be aligned to a cluster boundary. If the > offset is 0, the L2 table and all clusters described by this > L2 table are unallocated. > @@ -268,9 +268,9 @@ Standard Cluster Descriptor: > > With version 2, this is always 0. > > - 1 - 8: Reserved (set to 0) > + 1 - 7: Reserved (set to 0) > > - 9 - 55: Bits 9-55 of host cluster offset. Must be aligned to a > + 8 - 55: Bits 9-55 of host cluster offset. Must be aligned to a Comment? > cluster boundary. If the offset is 0, the cluster is > unallocated. > >