From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43282)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Vxh5h-0002oC-5r
	for qemu-devel@nongnu.org; Mon, 30 Dec 2013 12:57:29 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Vxh5a-0003xU-Rk
	for qemu-devel@nongnu.org; Mon, 30 Dec 2013 12:57:25 -0500
Received: from mail-qa0-x232.google.com ([2607:f8b0:400d:c00::232]:35872)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Vxh5a-0003xP-Io
	for qemu-devel@nongnu.org; Mon, 30 Dec 2013 12:57:18 -0500
Received: by mail-qa0-f50.google.com with SMTP id i13so10915657qae.16
	for <qemu-devel@nongnu.org>; Mon, 30 Dec 2013 09:57:18 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <52C1B3F9.3090205@twiddle.net>
Date: Mon, 30 Dec 2013 09:57:13 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1388421275-2035-1-git-send-email-peter.maydell@linaro.org>
	<1388421275-2035-2-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1388421275-2035-2-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 01/10] target-arm: A64: Add support for
 dumping AArch64 VFP register state
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>, patches@linaro.org, Michael Matz <matz@suse.de>, Alexander Graf <agraf@suse.de>, Claudio Fontana <claudio.fontana@linaro.org>, Dirk Mueller <dmueller@suse.de>, Will Newton <will.newton@linaro.org>, Laurent Desnogues <laurent.desnogues@gmail.com>, =?ISO-8859-1?Q?Alex_Benn=E9e?= <alex.bennee@linaro.org>, kvmarm@lists.cs.columbia.edu, Christoffer Dall <christoffer.dall@linaro.org>

On 12/30/2013 08:34 AM, Peter Maydell wrote:
> From: Alexander Graf <agraf@suse.de>
> 
> When dumping the current CPU state, we can also get a request
> to dump the FPU state along with the CPU's integer state.
> 
> Add support to dump the VFP state when that flag is set, so that
> we can properly debug code that modifies floating point registers.
> 
> Signed-off-by: Alexander Graf <agraf@suse.de>
> [WN: Commit message tweak, rebased. Output all registers, two per-line.]
> Signed-off-by: Will Newton <will.newton@linaro.org>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  target-arm/translate-a64.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~