From: Josh Durgin <josh.durgin@inktank.com>
To: Rutger ter Borg <rutger@terborg.net>, ceph-devel@vger.kernel.org
Subject: Re: [PATCH] fix librados aio read buffer handling
Date: Mon, 30 Dec 2013 12:00:36 -0800 [thread overview]
Message-ID: <52C1D0E4.9060108@inktank.com> (raw)
In-Reply-To: <l74blq$9ia$1@ger.gmane.org>
On 11/27/2013 12:49 AM, Rutger ter Borg wrote:
> On 2013-10-01 00:52, Josh Durgin wrote:
>>
>> I'm fine applying this now (with one fix). It's a nice cleanup
>> even if things change more soon.
>>
>> For the C interface, the return value stored in the AioCompletionImpl
>> needs to be the length read, so the caller can tell if a short read
>> occurred (this is only possible when trying to read past the end of an
>> object). This was being set in C_aio_Ack::finish(), but was removed by
>> this patch.
>
> Please find attached a revised patch against 0.72.1. I've added a fix
> for setting the return value in C_aio_Ack::finish(),
>
> if (c->bl.length() > 0) {
> c->rval = c->bl.length();
> }
Sorry for the delay - I just added this to the master branch.
Thanks!
Josh
prev parent reply other threads:[~2013-12-30 20:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-30 10:13 [PATCH] fix librados aio read buffer handling Rutger ter Borg
2013-09-30 15:38 ` Sage Weil
2013-09-30 22:52 ` Josh Durgin
2013-09-30 23:14 ` Sage Weil
2013-11-27 8:49 ` Rutger ter Borg
2013-12-30 20:00 ` Josh Durgin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52C1D0E4.9060108@inktank.com \
--to=josh.durgin@inktank.com \
--cc=ceph-devel@vger.kernel.org \
--cc=rutger@terborg.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.