From: Larry Finger <Larry.Finger@lwfinger.net>
To: Tim Jester-Pfadt <t.jp@gmx.de>, gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: rtl8188eu: Fixed coding style issues
Date: Mon, 30 Dec 2013 21:38:41 -0600 [thread overview]
Message-ID: <52C23C41.6090003@lwfinger.net> (raw)
In-Reply-To: <1388458437-25362-1-git-send-email-t.jp@gmx.de>
On 12/30/2013 08:53 PM, Tim Jester-Pfadt wrote:
> Fixed required and prohibited spaces to make rtw_io.h checkpatch.pl clean
>
> Signed-off-by: Tim Jester-Pfadt <t.jp@gmx.de>
> ---
> drivers/staging/rtl8188eu/include/rtw_io.h | 36 +++++++++++++++---------------
> 1 file changed, 18 insertions(+), 18 deletions(-)
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry
>
> diff --git a/drivers/staging/rtl8188eu/include/rtw_io.h b/drivers/staging/rtl8188eu/include/rtw_io.h
> index eb6f0e5..3d1dfcc 100644
> --- a/drivers/staging/rtl8188eu/include/rtw_io.h
> +++ b/drivers/staging/rtl8188eu/include/rtw_io.h
> @@ -123,7 +123,7 @@ struct _io_ops {
> u8 *pmem);
> u32 (*_write_port)(struct intf_hdl *pintfhdl, u32 addr, u32 cnt,
> u8 *pmem);
> - u32 (*_write_scsi)(struct intf_hdl *pintfhdl,u32 cnt, u8 *pmem);
> + u32 (*_write_scsi)(struct intf_hdl *pintfhdl, u32 cnt, u8 *pmem);
> void (*_read_port_cancel)(struct intf_hdl *pintfhdl);
> void (*_write_port_cancel)(struct intf_hdl *pintfhdl);
> };
> @@ -213,7 +213,7 @@ struct reg_protocol_wt {
> u32 Value;
> #else
> /* DW1 */
> - u32 Reserved1 :4;
> + u32 Reserved1:4;
> u32 NumOfTrans:4;
> u32 Reserved2:24;
> /* DW2 */
> @@ -254,7 +254,7 @@ struct io_priv {
> };
>
> uint ioreq_flush(struct adapter *adapter, struct io_queue *ioqueue);
> -void sync_ioreq_enqueue(struct io_req *preq,struct io_queue *ioqueue);
> +void sync_ioreq_enqueue(struct io_req *preq, struct io_queue *ioqueue);
> uint sync_ioreq_flush(struct adapter *adapter, struct io_queue *ioqueue);
> uint free_ioreq(struct io_req *preq, struct io_queue *pio_queue);
> struct io_req *alloc_ioreq(struct io_queue *pio_q);
> @@ -368,20 +368,20 @@ void free_io_queue(struct adapter *adapter);
> void async_bus_io(struct io_queue *pio_q);
> void bus_sync_io(struct io_queue *pio_q);
> u32 _ioreq2rwmem(struct io_queue *pio_q);
> -void dev_power_down(struct adapter * Adapter, u8 bpwrup);
> -
> -#define PlatformEFIOWrite1Byte(_a,_b,_c) \
> - rtw_write8(_a,_b,_c)
> -#define PlatformEFIOWrite2Byte(_a,_b,_c) \
> - rtw_write16(_a,_b,_c)
> -#define PlatformEFIOWrite4Byte(_a,_b,_c) \
> - rtw_write32(_a,_b,_c)
> -
> -#define PlatformEFIORead1Byte(_a,_b) \
> - rtw_read8(_a,_b)
> -#define PlatformEFIORead2Byte(_a,_b) \
> - rtw_read16(_a,_b)
> -#define PlatformEFIORead4Byte(_a,_b) \
> - rtw_read32(_a,_b)
> +void dev_power_down(struct adapter *Adapter, u8 bpwrup);
> +
> +#define PlatformEFIOWrite1Byte(_a, _b, _c) \
> + rtw_write8(_a, _b, _c)
> +#define PlatformEFIOWrite2Byte(_a, _b, _c) \
> + rtw_write16(_a, _b, _c)
> +#define PlatformEFIOWrite4Byte(_a, _b, _c) \
> + rtw_write32(_a, _b, _c)
> +
> +#define PlatformEFIORead1Byte(_a, _b) \
> + rtw_read8(_a, _b)
> +#define PlatformEFIORead2Byte(_a, _b) \
> + rtw_read16(_a, _b)
> +#define PlatformEFIORead4Byte(_a, _b) \
> + rtw_read32(_a, _b)
>
> #endif /* _RTL8711_IO_H_ */
>
next prev parent reply other threads:[~2013-12-31 3:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-31 2:53 [PATCH] Staging: rtl8188eu: Fixed coding style issues Tim Jester-Pfadt
2013-12-31 3:38 ` Larry Finger [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-01-02 17:03 Tim Jester-Pfadt
2014-01-02 17:53 ` Larry Finger
2016-04-30 8:30 [PATCH] Staging: rtl8188eu: fixed " Jacky Boen
2016-04-30 16:15 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52C23C41.6090003@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=t.jp@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.