Re: [Xenomai] [PATCH] hal/arm: Add Zynq v3.5.7 patches

[Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>]

On 12/31/2013 07:13 AM, Stefan Roese wrote:
> On 30.12.2013 22:48, Gilles Chanteperdrix wrote:
>> On 12/30/2013 04:15 PM, Stefan Roese wrote:
>>> Xilinx Zynq is already supported in the mainline Xenomai git repository.
>>> This patch adds support for the v3.5.7 Linux Kernel with the latest
>>> arm-6 i-pipe patch additionally to the already present v3.8 support.
>>
>> Sorry, I can not take these patches:
>> - they contain changes in the I-pipe core not related to the Zynq
>> architecture, these should be submitted separately as patches to the
>> I-pipe git itself;
> 
> Okay.
> 
>> - they contain changes in the Linux code, not related to Zynq either,
>> probably due to a mismatch between the stable revision you are using. In
>> order to use a more recent revision, please post a patch modifying the
>> I-pipe git to use that more recent stable revision;
> 
> Its the other way around. The Xilinx code is based on Linux v3.5. And
> the i-pipe patch is based on v3.5.7. So the pre-patch also includes the
> move for the xilinx code from v3.5 to v3.5.7.
> 
>> - they contain a defconfig file, if you want to make that file
>> available, please put it to some ftp or http server somewhere and put
>> the URL in the readme;
> 
> Okay.
> 
>> Really, the pre and post patches should be short, here they are enormous.
> 
> Mostly because of the v3.5 -> v3.5.7 move for the Xilinx code. Should I
> post this v3.5 -> v3.5.7 diff as a separate patch?
> 

One solution would be to dig the 3.5.0 patches from the I-pipe git, but
that would mean backporting changes that were done later, and having to
retest with 3.5 instead of 3.5.7.

Another solution would be to get the Xilinx tree updated, and send
patches to that updated tree. If you can publish your updated git tree
for the Xilinx tree, then base your pre- and post- patches on that
updated git tree (it simply means that the README will contain
references to the git tree you publish instead of Xilinx tree, so, it
will not be much more complicated for users, they already have to use
git anyway).

So all in all, if you do not want to bother, we will keep things like
you did.

Regards?


-- 
                                                                Gilles.