From: Jeff Liu <jeff.liu@oracle.com>
To: Mark Tinguely <tinguely@sgi.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH 2/10] xfs: xfs_bulkstat_single consolidation
Date: Tue, 31 Dec 2013 17:51:33 +0800 [thread overview]
Message-ID: <52C293A5.1000606@oracle.com> (raw)
In-Reply-To: <52C1BCE5.1070707@sgi.com>
On 2013年12月31日 02:35, Mark Tinguely wrote:
> On 12/28/13 05:20, Jeff Liu wrote:
>> From: Jie Liu<jeff.liu@oracle.com>
>>
>> In xfs_bulkstat_single(), xfs_bulkstat_one() and xfs_bulkstat() might
>> return different error if either call failed, we'd better return the
>> proper error in this case. Moreover, the function argument done is
>> useless in terms of xfs_ioc_bulkstat(), hence we can get rid of it.
>>
>> Signed-off-by: Jie Liu<jeff.liu@oracle.com>
>> ---
>
> Yes, I know dmapi is not loved here but SGI still uses it and it wants
> the done flag still..
My mistake. At that time, I noticed that there has comments about this
in xfs_ioc_bulkstat(), i.e,
/* done = 1 if there are more stats to get and if bulkstat */
/* should be called again (unused here, but used in dmapi) */
However, I failed to find out why it would be called by going through
the dmapi source code...
I'll keep this argument in next round of post.
Thanks,
-Jeff
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-12-31 9:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-28 11:20 [PATCH 2/10] xfs: xfs_bulkstat_single consolidation Jeff Liu
2013-12-30 18:35 ` Mark Tinguely
2013-12-31 9:51 ` Jeff Liu [this message]
2014-01-02 1:12 ` Dave Chinner
2014-01-02 7:23 ` Jeff Liu
2014-01-02 22:38 ` Dave Chinner
2014-01-03 20:52 ` Brian Foster
2014-01-04 13:46 ` Jeff Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52C293A5.1000606@oracle.com \
--to=jeff.liu@oracle.com \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.