From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47949)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Vy09e-0000cJ-OQ
	for qemu-devel@nongnu.org; Tue, 31 Dec 2013 09:18:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Vy09Y-0003a6-Tx
	for qemu-devel@nongnu.org; Tue, 31 Dec 2013 09:18:46 -0500
Received: from mail-pb0-x22b.google.com ([2607:f8b0:400e:c01::22b]:55486)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Vy09Y-0003a0-Hv
	for qemu-devel@nongnu.org; Tue, 31 Dec 2013 09:18:40 -0500
Received: by mail-pb0-f43.google.com with SMTP id rq2so12680192pbb.2
	for <qemu-devel@nongnu.org>; Tue, 31 Dec 2013 06:18:39 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <52C2D23B.4050309@twiddle.net>
Date: Tue, 31 Dec 2013 06:18:35 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1388496958-3542-1-git-send-email-peter.maydell@linaro.org>
	<1388496958-3542-3-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1388496958-3542-3-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 02/22] softfloat: Add float to 16bit
	integer conversions.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Tom Musta <tommusta@gmail.com>, Peter Crosthwaite <peter.crosthwaite@xilinx.com>, patches@linaro.org, Aurelien Jarno <aurelien@aurel32.net>, Michael Matz <matz@suse.de>, Alexander Graf <agraf@suse.de>, Claudio Fontana <claudio.fontana@linaro.org>, Dirk Mueller <dmueller@suse.de>, Will Newton <will.newton@linaro.org>, Laurent Desnogues <laurent.desnogues@gmail.com>, =?ISO-8859-1?Q?Alex_Benn=E9e?= <alex.bennee@linaro.org>, kvmarm@lists.cs.columbia.edu, Christoffer Dall <christoffer.dall@linaro.org>

On 12/31/2013 05:35 AM, Peter Maydell wrote:
> +    int64_t v;
> +    int_fast16_t res;
> +    int old_exc_flags = get_float_exception_flags(status);
> +
> +    v = float32_to_int64(a STATUS_VAR);

Any good reason not to use int32 as the intermediate, for the benefit of 32-bit
hosts?

Otherwise,

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~