From: Arjan van de Ven <arjan@linux.intel.com>
To: David Rientjes <rientjes@google.com>, Ingo Molnar <mingo@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
peterz@infradead.org, Andrew Morton <akpm@linux-foundation.org>,
linux@arm.linux.org.uk, ralf@linux-mips.org, tglx@linutronix.de,
"H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, james.hogan@imgtec.com,
Michal Marek <mmarek@suse.cz>,
lethal@linux-sh.org, shawn.guo@linaro.org,
Kees Cook <keescook@chromium.org>,
sfr@canb.auug.org.au, linux-kbuild@vger.kernel.org,
linux-tip-commits@vger.kernel.org
Subject: Re: [patch core/stackprotector] stackprotector: Fix build when compiler lacks support
Date: Tue, 31 Dec 2013 06:39:15 -0800 [thread overview]
Message-ID: <52C2D713.5050501@linux.intel.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1312301331520.10482@chino.kir.corp.google.com>
On 12/30/2013 1:37 PM, David Rientjes wrote:
> 8779657d29c0 ("stackprotector: Introduce CONFIG_CC_STACKPROTECTOR_STRONG")
> causes the build to break when the compiler doesn't support
> -fstack-protector-strong:
>
> cc1: error: unrecognized command line option ‘-fstack-protector-strong’
> cc1: error: unrecognized command line option ‘-fstack-protector-strong’
>
> with at least gcc 4.6.3.
>
> Instead of breaking the build, just warn of the failure and disable the
> feature.
ideally it also falls back to the less strict one, rather than not using stack protector at all...
prev parent reply other threads:[~2013-12-31 14:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 19:35 [PATCH v5] provide -fstack-protector-strong build option Kees Cook
2013-12-19 19:35 ` Kees Cook
2013-12-19 19:35 ` Kees Cook
2013-12-19 19:35 ` [PATCH v5 1/2] create HAVE_CC_STACKPROTECTOR for centralized use Kees Cook
2013-12-19 19:35 ` Kees Cook
2013-12-19 19:35 ` Kees Cook
2013-12-20 11:54 ` [tip:core/stackprotector] stackprotector: Unify the HAVE_CC_STACKPROTECTOR logic between architectures tip-bot for Kees Cook
2013-12-19 19:35 ` [PATCH v5 2/2] provide -fstack-protector-strong build option Kees Cook
2013-12-19 19:35 ` Kees Cook
2013-12-19 19:35 ` Kees Cook
2013-12-20 11:54 ` [tip:core/stackprotector] stackprotector: Introduce CONFIG_CC_STACKPROTECTOR_STRONG tip-bot for Kees Cook
2013-12-30 21:37 ` [patch core/stackprotector] stackprotector: Fix build when compiler lacks support David Rientjes
2013-12-31 0:45 ` Kees Cook
2014-01-01 0:16 ` Linus Torvalds
2014-01-01 11:42 ` Yann E. MORIN
2014-01-01 19:33 ` Linus Torvalds
2014-01-01 19:50 ` H. Peter Anvin
2014-01-01 22:28 ` Yann E. MORIN
2014-01-05 22:13 ` Sam Ravnborg
2013-12-31 14:39 ` Arjan van de Ven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52C2D713.5050501@linux.intel.com \
--to=arjan@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=james.hogan@imgtec.com \
--cc=keescook@chromium.org \
--cc=lethal@linux-sh.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mingo@kernel.org \
--cc=mmarek@suse.cz \
--cc=peterz@infradead.org \
--cc=ralf@linux-mips.org \
--cc=rientjes@google.com \
--cc=sfr@canb.auug.org.au \
--cc=shawn.guo@linaro.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.