From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Eli Cohen <eli@dev.mellanox.co.il>
Cc: Stephen Hemminger <shemming@brocade.com>,
Eli Cohen <eli@mellanox.com>, David Miller <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] mlx5: remove dead code
Date: Tue, 31 Dec 2013 21:45:55 +0300 [thread overview]
Message-ID: <52C310E3.8070401@cogentembedded.com> (raw)
In-Reply-To: <20131231160306.GA20236@mtldesk30>
Hello.
On 12/31/2013 07:03 PM, Eli Cohen wrote:
> Thanks. I noticed that and will address in the next patch set I plan
> to send.
Noticed what? Unused functions? They were removed by Stephen, not me.
>>> There are 3 functions in the mlx5 driver which are used and should be
>> s/used/unused/, I think.
>>> deleted. Upstream is not the repository to hold old dead code, or code
>>> which is used by outside drivers, or code intended for future undetermined
>>> features.
>>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
WBR, Sergei
prev parent reply other threads:[~2013-12-31 17:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-29 21:51 [PATCH net-next] mlx5: remove dead code Stephen Hemminger
2013-12-30 11:56 ` Sergei Shtylyov
2013-12-31 16:03 ` Eli Cohen
2013-12-31 18:45 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52C310E3.8070401@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=eli@dev.mellanox.co.il \
--cc=eli@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=shemming@brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.