From: Daniel Borkmann <dborkman@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: nicolas.dichtel@6wind.com, netdev@vger.kernel.org,
darkjames-ws@darkjames.pl
Subject: Re: [PATCH net-next v3 2/2] netlink: specify netlink packet direction for nlmon
Date: Wed, 01 Jan 2014 05:16:49 +0100 [thread overview]
Message-ID: <52C396B1.8010503@redhat.com> (raw)
In-Reply-To: <20131231.135008.1712348847039091134.davem@davemloft.net>
On 12/31/2013 07:50 PM, David Miller wrote:
> From: Daniel Borkmann <dborkman@redhat.com>
> Date: Mon, 23 Dec 2013 18:54:31 +0100
>
>> We could entirely remove it as it was e.g. proposed in 2008 [1]
>> already if you see any value in that. Eventually it's up to Dave and
>> if he likes, I'll be happy to send a patch that removes this define.
>
> Removing user visible defines can break source builds, for example
> someone building string tables or auto-generating things to facilitate
> accessing these values from languages other than C.
>
> It's harmless, since nobody semantically expects anything of it, but
> we have to keep it around.
Ok, that's fine by me.
Thanks for applying Dave and a happy new year!
Best,
Daniel
next prev parent reply other threads:[~2014-01-01 4:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-23 13:35 [PATCH net-next v3 0/2] nlmon updates Daniel Borkmann
2013-12-23 13:35 ` [PATCH net-next v3 1/2] netlink: only do not deliver to tap when both sides are kernel sks Daniel Borkmann
2013-12-23 13:35 ` [PATCH net-next v3 2/2] netlink: specify netlink packet direction for nlmon Daniel Borkmann
2013-12-23 17:46 ` Nicolas Dichtel
2013-12-23 17:54 ` Daniel Borkmann
2013-12-31 18:50 ` David Miller
2014-01-01 4:16 ` Daniel Borkmann [this message]
2013-12-31 19:32 ` [PATCH net-next v3 0/2] nlmon updates David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52C396B1.8010503@redhat.com \
--to=dborkman@redhat.com \
--cc=darkjames-ws@darkjames.pl \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.