Re: [RFC]iio:industrialio-event fix error-handling in iio_device_add_event

[Jonathan Cameron <jic23@kernel.org>]

On 29/12/13 11:54, Hartmut Knaack wrote:
> __iio_add_chan_devattr returns -EBUSY, when registering the event-interface of
> ad799x, but iio_device_add_event does not catch it. So, handle it like in
> iio_device_add_info_mask_type. Not sure, if this is the right solution, but it
> makes the ad799x (and possibly others as well) usable.
>
> Signed-off-by: Hartmut Knaack <knaack.h@gmx.de>
I think the fix is correct, but I'm not entirely sure what is triggering 
the bug in this particular driver. All of the elements of ad799x_events 
are in mask separate so shared_by should be IIO_SEPARATE for all calls 
to this function.

Lars, any idea's on what Hartmut is hitting?
Also, is the below patch as valid as it appears at first glance?

> ---
> diff --git a/drivers/iio/industrialio-event.c b/drivers/iio/industrialio-event.c
> index c10eab6..d37a907 100644
> --- a/drivers/iio/industrialio-event.c
> +++ b/drivers/iio/industrialio-event.c
> @@ -362,7 +362,9 @@ static int iio_device_add_event(struct iio_dev *indio_dev,
>   			&indio_dev->event_interface->dev_attr_list);
>   		kfree(postfix);
>
> -		if (ret)
> +		if ((ret == -EBUSY) && (shared_by != IIO_SEPARATE))
> +			continue;
> +		else if (ret < 0)
>   			return ret;
>
>   		attrcount++;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>