From: Lars-Peter Clausen <lars@metafoo.de>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] ASoC: ssm2518: Fix off-by-one error by ffs()
Date: Wed, 01 Jan 2014 16:42:39 +0100 [thread overview]
Message-ID: <52C4376F.7000809@metafoo.de> (raw)
In-Reply-To: <1387795375-17083-1-git-send-email-tiwai@suse.de>
On 12/23/2013 11:42 AM, Takashi Iwai wrote:
> ffs() returns the bit position from 1, while the ssm2158 driver code
> assumes it being 0-based. Also, the bit mask computation of the two
> channel slots are incorrect; it must have worked just casually.
>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Looks good, thanks.
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
next prev parent reply other threads:[~2014-01-01 15:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-23 10:42 [PATCH] ASoC: ssm2518: Fix off-by-one error by ffs() Takashi Iwai
2014-01-01 15:42 ` Lars-Peter Clausen [this message]
2014-01-02 11:54 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52C4376F.7000809@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.