From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56257)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1VyY3s-00082F-1o
	for qemu-devel@nongnu.org; Wed, 01 Jan 2014 21:31:12 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1VyY3j-0004PI-5R
	for qemu-devel@nongnu.org; Wed, 01 Jan 2014 21:31:04 -0500
Received: from e23smtp04.au.ibm.com ([202.81.31.146]:40772)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1VyY3i-0004P5-B2
	for qemu-devel@nongnu.org; Wed, 01 Jan 2014 21:30:55 -0500
Received: from /spool/local
	by e23smtp04.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <xiawenc@linux.vnet.ibm.com>;
	Thu, 2 Jan 2014 12:30:47 +1000
Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21])
	by d23dlp02.au.ibm.com (Postfix) with ESMTP id F30F72BB0053
	for <qemu-devel@nongnu.org>; Thu,  2 Jan 2014 13:30:44 +1100 (EST)
Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96])
	by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	s022UVeQ64618606
	for <qemu-devel@nongnu.org>; Thu, 2 Jan 2014 13:30:32 +1100
Received: from d23av01.au.ibm.com (localhost [127.0.0.1])
	by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id
	s022UhUV001953
	for <qemu-devel@nongnu.org>; Thu, 2 Jan 2014 13:30:44 +1100
Message-ID: <52C4CF51.5040507@linux.vnet.ibm.com>
Date: Thu, 02 Jan 2014 10:30:41 +0800
From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1384307094-5836-1-git-send-email-xiawenc@linux.vnet.ibm.com>
	<1384307094-5836-5-git-send-email-xiawenc@linux.vnet.ibm.com>
	<52AB0D51.5060208@redhat.com> <52AE6BA0.4000207@linux.vnet.ibm.com>
	<52AE6FB2.4070002@linux.vnet.ibm.com>
In-Reply-To: <52AE6FB2.4070002@linux.vnet.ibm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH RFC 3/3] tests: add test cases for
 qapi	event support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, pbonzini@redhat.com, mdroth@linux.vnet.ibm.com, armbru@redhat.com, lcapitulino@redhat.com

>>>
>>>> + OrderedDict([('event', 'EVENT_A')]),
>>>> + OrderedDict([('event', 'EVENT_B'), ('data', OrderedDict())]),
>>>
>>> Shouldn't the omission of 'data' be the same as 'data':{}?
>>>
>>
>>    I didn't touch the "{ }" parsing part, maybe an existing parsing
>> style, will check it.
>>

   Checked the code, it is generated by tests/qapi-schema/test-qapi.py:

try:
     exprs = parse_schema(sys.stdin)
except SystemExit:
     raise
except:
     print >>sys.stderr, "Crashed:", sys.exc_info()[0]
     exit(1)

pprint(exprs)

   I think it worked as expectation for exprs.

>>>> +++ b/tests/test-qmp-event.c
>>>> @@ -0,0 +1,250 @@
>>>> +/*
>>>> + * QMP Input Visitor unit-tests.
>>>> + *
>>>> + * Copyright (C) 2011 Red Hat Inc.
>>>
>>> Unusual choice of copyright year and ownership.
>>>
>>   yep, will fix.
>>
>>
>
>