From: Jane Li <jiel@marvell.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cpufreq: Fix timer/workqueue corruption by protecting reading governor_enabled
Date: Thu, 2 Jan 2014 11:15:44 +0800 [thread overview]
Message-ID: <52C4D9E0.5070501@marvell.com> (raw)
In-Reply-To: <CAKohpomwA0PHBvFiK+-i6LDHX8J_s2hfm4-ciKFB9DSS8q0Wdw@mail.gmail.com>
>> Yes, I test it. After adding cpufreq_governor_lock in gov_queue_work() and
>> running same test, there is no debugobjects warning.
> But it really can't work at all.. There should be a separate copy of lock
> in every file that includes cpufreq.h.. And so this shouldn't have worked.
>
Oh.. I understand what you mean now. My patch is not right and cannot fix this issue.
By default, the debugobjects warning sometimes occurs after five minutes, and sometimes occurs after twenty hours. With this patch, I test more than fifty hours, and warning did not occurs. It shows that my test time is not long enough and miss the right one.
I have updated PATCH v2, please review again. Thanks.
prev parent reply other threads:[~2014-01-02 3:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-27 9:30 [PATCH] cpufreq: Fix timer/workqueue corruption by protecting reading governor_enabled jiel
2013-12-27 9:30 ` jiel
2013-12-27 9:40 ` Viresh Kumar
2013-12-30 6:29 ` Jane Li
2013-12-30 6:34 ` Viresh Kumar
2014-01-02 3:15 ` Jane Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52C4D9E0.5070501@marvell.com \
--to=jiel@marvell.com \
--cc=cpufreq@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.