From mboxrd@z Thu Jan 1 00:00:00 1970 From: chenweilong Subject: Re: [PATCH] ipv6: don't call addrconf_dst_alloc again when enable lo Date: Thu, 2 Jan 2014 13:48:46 +0800 Message-ID: <52C4FDBE.5030607@huawei.com> References: <1371352470-3226-1-git-send-email-gaofeng@cn.fujitsu.com> <20130619.230532.1329281330568271336.davem@davemloft.net> <20131231035718.GB27636@order.stressinduktion.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit To: David Miller , , , Return-path: Received: from szxga01-in.huawei.com ([119.145.14.64]:29923 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750710AbaABFtA (ORCPT ); Thu, 2 Jan 2014 00:49:00 -0500 In-Reply-To: <20131231035718.GB27636@order.stressinduktion.org> Sender: netdev-owner@vger.kernel.org List-ID: On 2013/12/31 11:57, Hannes Frederic Sowa wrote: > On Wed, Jun 19, 2013 at 11:05:32PM -0700, David Miller wrote: >> From: Gao feng >> Date: Sun, 16 Jun 2013 11:14:30 +0800 >> >>> If we disable all of the net interfaces, and enable >>> un-lo interface before lo interface, we already allocated >>> the addrconf dst in ipv6_add_addr. So we shouldn't allocate >>> it again when we enable lo interface. >>> >>> Otherwise the message below will be triggered. >>> unregister_netdevice: waiting for sit1 to become free. Usage count = 1 >>> >>> This problem is introduced by commit 25fb6ca4ed9cad72f14f61629b68dc03c0d9713f >>> "net IPv6 : Fix broken IPv6 routing table after loopback down-up" >>> >>> Signed-off-by: Gao feng >> >> This is the second such regression added by that commit :-/ >> >> Applied and queue up for -stable, thanks. > > Hmm, and this change also has a regression and breaks the original fix. :/ > > https://bugzilla.kernel.org/show_bug.cgi?id=67951 > > I tried to track it down but it seems pretty complicated. Maybe we have to > special-case the take-down of the loopback device. > > > Hi, When I did the tests,If 'ifconfig lo down',all IPv6 connection broken, but IPv4 connection were still OK. Is it designed like that or a bug? Thanks