From: bilhuang <bilhuang@nvidia.com>
To: Viresh Kumar <viresh.kumar@linaro.org>,
Stephen Warren <swarren@wwwdotorg.org>,
Rob Herring <robherring2@gmail.com>,
Grant Likely <grant.likely@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Thierry Reding <thierry.reding@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH v5 1/1] cpufreq: tegra: Re-model Tegra20 cpufreq driver
Date: Thu, 2 Jan 2014 19:08:38 +0800 [thread overview]
Message-ID: <52C548B6.60902@nvidia.com> (raw)
In-Reply-To: <CAKohpokwO3BgXr9Le02bNo=771saWuDe2H=fgQzcboRWxwVzOg@mail.gmail.com>
On 12/23/2013 01:06 PM, Viresh Kumar wrote:
> Ccc'ing Grant and Rob as well.
>
> On 20 December 2013 21:59, Stephen Warren <swarren@wwwdotorg.org> wrote:
>> No, I definitely don't agree here. The rules for arch/arm64 are: no
>> platform-specific code. We should immediately start planning for that.
>> If this means renaming the file that creates the virtual device from
>> tegra-cpufreq.c to something else, so be it, but we shouldn't go
>> backwards and push stuff into the arch directories.
>
> I don't mind doing this now as well if it is generic enough. I wasn't sure
> if you guys wanted to take it on now..
>
> @Bill: So, please create a separate commit for creating such file which
> would create a virtual device for probing cpufreq drivers with name picked
> from root-node. Compilation of such a file should be configurable but if
> it is compiled, then it shouldn't cause any problems if that device isn't
> used, for multiplatform kernels specially..
>
> Probably then you can widen the scope of your patchset by modifying
> some of the existing drivers which require a device to get cpufreq
> driver probed. Currently they are all making such a device from
> their arch/ stuff.
Actually, I don't have plan or resource on doing this, would it be
better that you help to do that instead? Thanks.
>
> I am not sure about the location of such file. Should this be placed in DT
> code somewhere or kept in cpufreq? Rob/Grant ??
>
Do we have consensus on where to create such file?
> --
> viresh
>
next prev parent reply other threads:[~2014-01-02 11:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 11:18 [PATCH v5 1/1] cpufreq: tegra: Re-model Tegra20 cpufreq driver Bill Huang
2013-12-19 11:18 ` Bill Huang
2013-12-19 19:33 ` Stephen Warren
2013-12-20 9:31 ` Viresh Kumar
2013-12-20 10:25 ` bilhuang
2013-12-20 10:33 ` Viresh Kumar
2013-12-20 10:42 ` bilhuang
2013-12-20 16:29 ` Stephen Warren
2013-12-23 5:06 ` Viresh Kumar
2014-01-02 11:08 ` bilhuang [this message]
2014-01-03 5:47 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52C548B6.60902@nvidia.com \
--to=bilhuang@nvidia.com \
--cc=cpufreq@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=robherring2@gmail.com \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.