From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <david.vrabel@citrix.com>
Subject: Re: [BUGFIX] [PATCH] kexec/x86: Do map crash kernel area
Date: Thu, 2 Jan 2014 11:49:47 +0000
Message-ID: <52C5525B.4040704@citrix.com>
References: <1388595096-15787-1-git-send-email-dslutz@verizon.com>
	<52C54388.105@citrix.com> <52C543E9.1050701@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <52C543E9.1050701@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, George Dunlap <george.dunlap@eu.citrix.com>, Daniel Kiper <daniel.kiper@oracle.com>, Don Slutz <dslutz@verizon.com>, xen-devel@lists.xen.org, Jan Beulich <jbeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

On 02/01/14 10:48, Andrew Cooper wrote:
> On 02/01/14 10:46, David Vrabel wrote:
>> On 01/01/14 16:51, Don Slutz wrote:
>>> Revert of commit 7113a45451a9f656deeff070e47672043ed83664
>> Since this commit introduced a regression, a revert is the best thing to
>> do here.
>>
>> Acked-by: David Vrabel <david.vrabel@citrix.com>
>>
>>> Using kexec commit 027413d822fd57dd39d2d2afab1484bc6b6b84f9
>>>
>>> With "crashkernel=256M@256M" ((XEN) Kdump: 256MB (262144kB) at 0x10000000)
>> I guess Daniel tested a debug build without this crashkernel option.
>> This would place the crash region above the direct mapping region and
>> map_domain_page() would do the right thing.
>>
>>
>>> +    map_pages_to_xen((unsigned long)__va(kexec_crash_area.start),
>>> +                     kexec_crash_area.start >> PAGE_SHIFT,
>>> +                     PFN_UP(kexec_crash_area.size), PAGE_HYPERVISOR);
>>> +
>> This should be made conditional on the location of the crash region --
>> it is wrong to do this for portions of the crash region that are outside
>> the crash region.
> 
> Presume you mean "outside the direct-map region"?

Yes.

David