diff for duplicates of <52C58138.1030301@citrix.com> diff --git a/a/1.txt b/N1/1.txt index 7422594..fef936f 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -102,7 +102,7 @@ On 31/12/13 14:32, Konrad Rzeszutek Wilk wrote: > + > + /* And user has xen_platform_pci=0 set in guest config as > + * driver did not modify the value. */ -> + if (xen_platform_pci_unplug = 0) +> + if (xen_platform_pci_unplug == 0) > + return false; > + > + if (xen_platform_pci_unplug & XEN_UNPLUG_NEVER) @@ -122,8 +122,8 @@ On 31/12/13 14:32, Konrad Rzeszutek Wilk wrote: This may result in: -xen_has_pv_devices() = false -xen_has_pv_disk_devices() = true +xen_has_pv_devices() == false +xen_has_pv_disk_devices() == true which looks odd to me. Surely xen_has_pv_*_devices() is a subset of xen_has_pv_devices()? diff --git a/a/content_digest b/N1/content_digest index 0c1af86..74a24ef 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -6,7 +6,7 @@ "ref\020131231143258.GA3018@phenom.dumpdata.com\0" "From\0David Vrabel <david.vrabel@citrix.com>\0" "Subject\0Re: [Xen-devel] [PATCH v3 1/2] xen/pvhvm: If xen_platform_pci=0 is set don't blow up (v3).\0" - "Date\0Thu, 02 Jan 2014 15:09:44 +0000\0" + "Date\0Thu, 2 Jan 2014 15:09:44 +0000\0" "To\0Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>\0" "Cc\0Fabio Fantoni <fabio.fantoni@m2r.biz>" axboe@kernel.dk @@ -136,7 +136,7 @@ "> +\n" "> +\t/* And user has xen_platform_pci=0 set in guest config as\n" "> +\t * driver did not modify the value. */\n" - "> +\tif (xen_platform_pci_unplug = 0)\n" + "> +\tif (xen_platform_pci_unplug == 0)\n" "> +\t\treturn false;\n" "> +\n" "> +\tif (xen_platform_pci_unplug & XEN_UNPLUG_NEVER)\n" @@ -156,12 +156,12 @@ "\n" "This may result in:\n" "\n" - "xen_has_pv_devices() = false\n" - "xen_has_pv_disk_devices() = true\n" + "xen_has_pv_devices() == false\n" + "xen_has_pv_disk_devices() == true\n" "\n" "which looks odd to me. Surely xen_has_pv_*_devices() is a subset of\n" "xen_has_pv_devices()?\n" "\n" David -e103f5204a1249f6e29e30c271eefce5c938a7e385bb449577f94c24dd24addb +43065bda0bb583e7c47f95b5048893566035ad4039dbd234ff80f8eba8ff787b
diff --git a/a/1.txt b/N2/1.txt index 7422594..fef936f 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -102,7 +102,7 @@ On 31/12/13 14:32, Konrad Rzeszutek Wilk wrote: > + > + /* And user has xen_platform_pci=0 set in guest config as > + * driver did not modify the value. */ -> + if (xen_platform_pci_unplug = 0) +> + if (xen_platform_pci_unplug == 0) > + return false; > + > + if (xen_platform_pci_unplug & XEN_UNPLUG_NEVER) @@ -122,8 +122,8 @@ On 31/12/13 14:32, Konrad Rzeszutek Wilk wrote: This may result in: -xen_has_pv_devices() = false -xen_has_pv_disk_devices() = true +xen_has_pv_devices() == false +xen_has_pv_disk_devices() == true which looks odd to me. Surely xen_has_pv_*_devices() is a subset of xen_has_pv_devices()? diff --git a/a/content_digest b/N2/content_digest index 0c1af86..41847b7 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -6,30 +6,30 @@ "ref\020131231143258.GA3018@phenom.dumpdata.com\0" "From\0David Vrabel <david.vrabel@citrix.com>\0" "Subject\0Re: [Xen-devel] [PATCH v3 1/2] xen/pvhvm: If xen_platform_pci=0 is set don't blow up (v3).\0" - "Date\0Thu, 02 Jan 2014 15:09:44 +0000\0" + "Date\0Thu, 2 Jan 2014 15:09:44 +0000\0" "To\0Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>\0" "Cc\0Fabio Fantoni <fabio.fantoni@m2r.biz>" - axboe@kernel.dk - leosilva@linux.vnet.ibm.com - linux-fbdev@vger.kernel.org - dmitry.torokhov@gmail.com - ian.campbell@citrix.com - stefano.stabellini@eu.citrix.com - linux-pci@vger.kernel.org - netdev@vger.kernel.org - ashley@ashleylai.com - tpmdd@selhorst.net - linux-kernel@vger.kernel.org - mail@srajiv.net - tpmdd-devel@lists.sourceforge.net - tomi.valkeinen@ti.com - david.vrabel@citrix.com - linux-input@vger.kernel.org - bhelgaas@google.com - xen-devel@lists.xenproject.org - boris.ostrovsky@oracle.com - plagnioj@jcrosoft.com - " peterhuewe@gmx.de\0" + <axboe@kernel.dk> + <leosilva@linux.vnet.ibm.com> + <linux-fbdev@vger.kernel.org> + <dmitry.torokhov@gmail.com> + <ian.campbell@citrix.com> + <stefano.stabellini@eu.citrix.com> + <linux-pci@vger.kernel.org> + <netdev@vger.kernel.org> + <ashley@ashleylai.com> + <tpmdd@selhorst.net> + <linux-kernel@vger.kernel.org> + <mail@srajiv.net> + <tpmdd-devel@lists.sourceforge.net> + <tomi.valkeinen@ti.com> + <david.vrabel@citrix.com> + <linux-input@vger.kernel.org> + <bhelgaas@google.com> + <xen-devel@lists.xenproject.org> + <boris.ostrovsky@oracle.com> + <plagnioj@jcrosoft.com> + " <peterhuewe@gmx.de>\0" "\00:1\0" "b\0" "On 31/12/13 14:32, Konrad Rzeszutek Wilk wrote:\n" @@ -136,7 +136,7 @@ "> +\n" "> +\t/* And user has xen_platform_pci=0 set in guest config as\n" "> +\t * driver did not modify the value. */\n" - "> +\tif (xen_platform_pci_unplug = 0)\n" + "> +\tif (xen_platform_pci_unplug == 0)\n" "> +\t\treturn false;\n" "> +\n" "> +\tif (xen_platform_pci_unplug & XEN_UNPLUG_NEVER)\n" @@ -156,12 +156,12 @@ "\n" "This may result in:\n" "\n" - "xen_has_pv_devices() = false\n" - "xen_has_pv_disk_devices() = true\n" + "xen_has_pv_devices() == false\n" + "xen_has_pv_disk_devices() == true\n" "\n" "which looks odd to me. Surely xen_has_pv_*_devices() is a subset of\n" "xen_has_pv_devices()?\n" "\n" David -e103f5204a1249f6e29e30c271eefce5c938a7e385bb449577f94c24dd24addb +f02fae0c5109c694408b48d2b4a6a116df1d75dbfba7b3da157297ade2de8b29
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.