From: Sebastian Schuberth <sschuberth@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] Fix safe_create_leading_directories() for Windows
Date: Thu, 02 Jan 2014 19:11:42 +0100 [thread overview]
Message-ID: <52C5ABDE.1010006@gmail.com> (raw)
In-Reply-To: <alpine.DEB.1.00.1401021826120.1191@s15462909.onlinehome-server.info>
On 02.01.2014 18:33, Johannes Schindelin wrote:
> -- snip --
> On Linux, we can get away with assuming that the directory separator is a
> forward slash, but that is wrong in general. For that purpose, the
> is_dir_sep() function was introduced a long time ago. By using it in
> safe_create_leading_directories(), we proof said function for use on
> platforms where the directory separator is different from Linux'.
> -- snap --
While I'd be fine with this, I do not think we really need it. As you
say, is_dir_sep() has been introduced a long time ago, so people should
be aware of it, and it should also be immediately clear from the diff
why using it is better than hard-coding '/'.
That said, I see any further explanations on top of the commit message
title is an added bonus, and as "just" a bonus a link to a pull request
should be fine. You don't need to understand or appreciate the concept
of pull requests in order to follow the link and read the text in there.
--
Sebastian Schuberth
next prev parent reply other threads:[~2014-01-02 18:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-02 17:22 [PATCH] Fix safe_create_leading_directories() for Windows Sebastian Schuberth
2014-01-02 17:33 ` Johannes Schindelin
2014-01-02 18:11 ` Sebastian Schuberth [this message]
2014-01-02 18:18 ` John Keeping
2014-01-02 20:37 ` Sebastian Schuberth
2014-01-02 20:46 ` Johannes Schindelin
2014-01-07 15:43 ` Erik Faye-Lund
2014-01-07 17:56 ` Johannes Schindelin
2014-01-07 21:49 ` Sebastian Schuberth
2014-01-02 19:55 ` Junio C Hamano
2014-01-02 20:42 ` Johannes Schindelin
2014-01-02 20:48 ` Sebastian Schuberth
2014-01-02 20:54 ` [PATCH v2] " Sebastian Schuberth
2014-01-02 21:10 ` Johannes Schindelin
2014-01-02 21:24 ` Junio C Hamano
2014-01-02 21:51 ` Junio C Hamano
2014-01-02 22:12 ` Junio C Hamano
2014-01-02 21:08 ` [PATCH] " Junio C Hamano
2014-01-02 21:19 ` Johannes Schindelin
2014-01-19 7:00 ` Sebastian Schuberth
2014-01-19 7:26 ` Sebastian Schuberth
2014-01-21 20:09 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52C5ABDE.1010006@gmail.com \
--to=sschuberth@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.