From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kleber Sacilotto de Souza Subject: Re: [PATCH] drm/radeon: Disable writeback by default on ppc Date: Thu, 02 Jan 2014 18:54:54 -0200 Message-ID: <52C5D21E.4040402@linux.vnet.ibm.com> References: <1371477978-25440-1-git-send-email-ajax@redhat.com> <1383863356.4776.202.camel@pasglop> <527CEA7D.4060704@linux.vnet.ibm.com> <1385334947.4882.153.camel@pasglop> <5293E73E.8050704@linux.vnet.ibm.com> <529FA9A5.4060706@linux.vnet.ibm.com> <1386207571.21910.0.camel@pasglop> <1386210592.31665.24.camel@thor.local> <1386216410.21910.3.camel@pasglop> <52A1D7E9.5080800@linux.vnet.ibm.com> <1386642057.32592.128.camel@thor.local> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Content-Transfer-Encoding: quoted-printable Return-path: Received: from e24smtp03.br.ibm.com (e24smtp03.br.ibm.com [32.104.18.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 373E8FB1E5 for ; Thu, 2 Jan 2014 12:55:01 -0800 (PST) Received: from /spool/local by e24smtp03.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 2 Jan 2014 18:54:58 -0200 Received: from d24relay03.br.ibm.com (d24relay03.br.ibm.com [9.13.184.25]) by d24dlp02.br.ibm.com (Postfix) with ESMTP id 6B3161DC006C for ; Thu, 2 Jan 2014 15:54:56 -0500 (EST) Received: from d24av01.br.ibm.com (d24av01.br.ibm.com [9.8.31.91]) by d24relay03.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s02KsUQv41091322 for ; Thu, 2 Jan 2014 18:54:30 -0200 Received: from d24av01.br.ibm.com (localhost [127.0.0.1]) by d24av01.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s02KstEq027597 for ; Thu, 2 Jan 2014 18:54:55 -0200 In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Alex Deucher Cc: =?ISO-8859-1?Q?Michel_D=E4nzer?= , Maling list - DRI developers , Jerome Glisse , Thadeu Lima de Souza Cascardo , Brian King List-Id: dri-devel@lists.freedesktop.org On 12/10/2013 01:12 PM, Alex Deucher wrote: > On Tue, Dec 10, 2013 at 10:04 AM, Alex Deucher wr= ote: >> On Mon, Dec 9, 2013 at 9:20 PM, Michel D=E4nzer wro= te: >>> On Mon, 2013-12-09 at 19:48 -0500, Alex Deucher wrote: >>>> >>>> -u32 cik_compute_ring_get_wptr(struct radeon_device *rdev, >>>> - struct radeon_ring *ring) >>>> +u32 cik_compute_get_wptr(struct radeon_device *rdev, >>>> + struct radeon_ring *ring) >>>> { >>>> u32 wptr; >>>> >>>> if (rdev->wb.enabled) { >>>> - wptr =3D le32_to_cpu(rdev->wb.wb[ring->wptr_offs/4]); >>>> + wptr =3D rdev->wb.wb[ring->wptr_offs/4]; >>>> } else { >>>> mutex_lock(&rdev->srbm_mutex); >>>> cik_srbm_select(rdev, ring->me, ring->pipe, >>>> ring->queue, 0); >>>> @@ -4053,8 +4081,8 @@ u32 cik_compute_ring_get_wptr(struct >>>> radeon_device *rdev, >>>> return wptr; >>>> } >>>> >>>> -void cik_compute_ring_set_wptr(struct radeon_device *rdev, >>>> - struct radeon_ring *ring) >>>> +void cik_compute_set_wptr(struct radeon_device *rdev, >>>> + struct radeon_ring *ring) >>>> { >>>> rdev->wb.wb[ring->wptr_offs/4] =3D cpu_to_le32(ring->wptr); >>> >>> I think this cpu_to_le32() needs to be dropped as well to match >>> cik_compute_ring_get_wptr(). >> >> whoops, yeah, missed that one. > > Updated patch attached. > > Alex > Hi, Alex. Has this patch been accepted upstream? I've tested it successfully on a = ppc64 system with a FirePro 2270 adapter. Thanks, -- = Kleber Sacilotto de Souza IBM Linux Technology Center