From: Paolo Bonzini <pbonzini@redhat.com>
To: Nathan Whitehorn <nwhitehorn@freebsd.org>
Cc: qemu-ppc <qemu-ppc@nongnu.org>, Alexander Graf <agraf@suse.de>,
ronnie sahlberg <ronniesahlberg@gmail.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH] spapr_vscsi: Fix REPORT_LUNS handling
Date: Thu, 02 Jan 2014 22:44:54 +0100 [thread overview]
Message-ID: <52C5DDD6.2060301@redhat.com> (raw)
In-Reply-To: <52C5AC9E.5060906@freebsd.org>
Il 02/01/2014 19:14, Nathan Whitehorn ha scritto:
>> > He should do something like :
>> > resp_data[i] |= dev->id & 0x3f;
>> > here to avoid a dev->id > 63 from spilling into the address method field.
>> >
>> > Or probably should have a check for
>> > if dev->id > 3 then fail
> OK.
No need for that:
.max_channel = 7, /* logical unit addressing format */
.max_target = 63,
.max_lun = 31,
dev->id is thus bounded to 0..63.
Paolo
next prev parent reply other threads:[~2014-01-02 21:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 12:33 [Qemu-devel] [PATCH] spapr_vscsi: Fix REPORT_LUNS handling Nathan Whitehorn
2013-12-02 17:51 ` Nathan Whitehorn
2013-12-02 17:58 ` Paolo Bonzini
2014-01-02 15:05 ` Nathan Whitehorn
2014-01-02 15:31 ` Alexander Graf
2014-01-02 15:41 ` [Qemu-devel] [Qemu-ppc] " Alexander Graf
2014-01-02 15:56 ` ronnie sahlberg
2014-01-02 18:14 ` Nathan Whitehorn
2014-01-02 21:44 ` Paolo Bonzini [this message]
2014-01-02 18:23 ` Nathan Whitehorn
2014-01-03 13:27 ` Paolo Bonzini
2014-01-12 22:35 ` Nathan Whitehorn
2014-01-02 18:28 ` [Qemu-devel] " Nathan Whitehorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52C5DDD6.2060301@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=nwhitehorn@freebsd.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=ronniesahlberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.