From: Larry Finger <Larry.Finger@lwfinger.net>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 24/31] staging: r8188eu: Additional cleanup of include/odm.h
Date: Thu, 02 Jan 2014 16:04:26 -0600 [thread overview]
Message-ID: <52C5E26A.5000704@lwfinger.net> (raw)
In-Reply-To: <20140102090516.GB5443@mwanda>
On 01/02/2014 03:05 AM, Dan Carpenter wrote:
> On Sun, Dec 22, 2013 at 05:36:55PM -0600, Larry Finger wrote:
>> --- a/drivers/staging/rtl8188eu/include/odm_interface.h
>> +++ b/drivers/staging/rtl8188eu/include/odm_interface.h
>> @@ -51,7 +51,7 @@ ODM_REG(DIG,_pDM_Odm)
>>
>> #define _cat(_name, _ic_type, _func) \
>> ( \
>> - ((_ic_type) & ODM_IC_11N_SERIES) ? _func##_11N(_name) : \
>> + (_ic_type) ? _func##_11N(_name) : \
>> _func##_11AC(_name) \
>> )
>
> The original version of this function was more readable... I think
> _ic_type is either zero or 16?
The original driver has some code that supports many different chips; however,
the present one only works for RTL8188E.
In the current driver, ODM_RTL8188E is always the only bit in odm_ic_type, thus
it is always 16. As a result (_ic_type & ODM_IC_11N_SERIES) is always equal to
_ic_type, which is why I simplified the macro.
If you really prefer the original version of the macro, I will leave it.
Larry
next prev parent reply other threads:[~2014-01-02 22:04 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-22 23:36 [PATCH 00/31] Staging: r8188eu: Various cleanups Larry Finger
2013-12-22 23:36 ` [PATCH 01/31] staging: r8188eu: Replace wrappers ODM_sleep_us and rtw_usleep_os Larry Finger
2013-12-22 23:36 ` [PATCH 02/31] staging: r8188eu: Replace wrapper rtw_yield_os Larry Finger
2013-12-22 23:36 ` [PATCH 03/31] staging: r8188eu: Remove wrapper code for rtw_suspend_lock_init, rtw_suspend_lock_uninit, rtw_lock_suspend, and rtw_unlock_suspend Larry Finger
2013-12-22 23:36 ` [PATCH 04/31] staging: r8188eu: Replace ATOMIC_T with atomic_t Larry Finger
2013-12-22 23:36 ` [PATCH 05/31] staging: r8188eu: Replace wrapper around atomic_set() Larry Finger
2013-12-22 23:36 ` [PATCH 06/31] staging: r8188eu: Remove unused atomic_xxx wrappers Larry Finger
2013-12-22 23:36 ` [PATCH 07/31] staging: r8188eu: Replace wrappers for atomic_inc and atomic_inc_return Larry Finger
2013-12-22 23:36 ` [PATCH 08/31] staging: r8188eu: Remove daemonize conditional Larry Finger
2013-12-22 23:36 ` [PATCH 09/31] staging: r8188eu: Replace wrapper around sema_init Larry Finger
2013-12-22 23:36 ` [PATCH 10/31] staging: r8188eu: Remove wrappers _rtw_free_sema, _rtw_up_sema, and _rtw_mutex_init Larry Finger
2013-12-22 23:36 ` [PATCH 11/31] staging: r8188eu: Remove wrapper around mutex_destroy Larry Finger
2013-12-22 23:36 ` [PATCH 12/31] staging: r8188eu: Remove macro ODM_SetBBReg Larry Finger
2013-12-22 23:36 ` [PATCH 13/31] staging: r8188eu: Remove macro ODM_GetBBReg Larry Finger
2013-12-22 23:36 ` [PATCH 14/31] staging: r8188eu: Remove macro ODM_SetRFReg Larry Finger
2013-12-22 23:36 ` [PATCH 15/31] staging: r8188eu: Remove macro ODM_GetRFReg Larry Finger
2013-12-22 23:36 ` [PATCH 16/31] staging: r8188eu: Remove macro ODM_SetMACReg Larry Finger
2013-12-22 23:36 ` [PATCH 17/31] staging: r8188eu: Remove macro ODM_GetMACReg Larry Finger
2013-12-22 23:36 ` [PATCH 18/31] staging: r8188eu: Remove - number of dummy and unused routines Larry Finger
2013-12-22 23:36 ` [PATCH 19/31] staging: r8188eu: Remove more empty routines Larry Finger
2013-12-22 23:36 ` [PATCH 20/31] staging: r8188eu: Remove even " Larry Finger
2013-12-22 23:36 ` [PATCH 21/31] staging: r8188eu: Simplify code concerning SupportPlatform Larry Finger
2013-12-22 23:36 ` [PATCH 22/31] staging: r8188eu: Simplify code related to SupportICType Larry Finger
2013-12-22 23:36 ` [PATCH 23/31] staging: r8188eu: Remove unneeded prototypes from include/odm.h Larry Finger
2013-12-22 23:36 ` [PATCH 24/31] staging: r8188eu: Additional cleanup of include/odm.h Larry Finger
2014-01-02 9:05 ` Dan Carpenter
2014-01-02 22:04 ` Larry Finger [this message]
2014-01-03 21:12 ` Dan Carpenter
2013-12-22 23:36 ` [PATCH 25/31] staging: r8188eu: Cleanup of include/hal_intf.h Larry Finger
2013-12-22 23:36 ` [PATCH 26/31] staging: r8188eu: Eliminate enum ODM_RADIO_PATH in favor of rf_radio_path Larry Finger
2013-12-22 23:36 ` [PATCH 27/31] staging: r8188eu: Fix sparse warning in core/rtw_sta_mgt.c Larry Finger
2013-12-22 23:36 ` [PATCH 28/31] staging: r8188eu: Fix sparse warning in core/rtw_pwrctrl.c Larry Finger
2013-12-22 23:37 ` [PATCH 29/31] staging: r8188eu: Fix sparse warning in core/rtw_xmit.c Larry Finger
2013-12-22 23:37 ` [PATCH 30/31] staging: r8188eu: Fix sparse warnings in core/rtw_br_ext.c Larry Finger
2014-01-02 8:36 ` Dan Carpenter
2013-12-22 23:37 ` [PATCH 31/31] staging: r8188eu: Fix smatch error Larry Finger
2014-01-02 8:44 ` Dan Carpenter
2014-01-02 22:19 ` Larry Finger
2014-01-09 3:18 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52C5E26A.5000704@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.