From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Fastabend Subject: Re: [RFC PATCH net-next 1/4] net: introduce backup_classid to struct skbuff Date: Thu, 02 Jan 2014 22:21:38 -0800 Message-ID: <52C656F2.8060803@gmail.com> References: <52C62A48.1050604@huawei.com> <20140103.003404.1439874071277993396.davem@davemloft.net> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=HJ5r1AR98xYnsH259kEd/YnHyd/FAISKdj/rzPc9GoE=; b=EzpZEBxnltQ5ltXpleRa8TQZz0LLGaD7hlqCt4o7RCy1c2mjskFJnGzeOkODXQc46W 2E6n2RFqWA3tQfeGsjBpYnX9VEO8j5ey45BuQWjz5GzyIQap0qynsVvb2I9RiZwim1dc 56NRIxdlYCfssOxmkwUoj8Gkz+KPrUIFw0gev76yMkZzczDJy2fEXvUWMt3FR5ZMuZ2J FIayNY6DwPD+C/9jC/E95snOi6jU0V5KcVm7e3HZlPI1haQKadCnBlMesIBViBSl3n9L oFNndWLkiGPm7hMf++14Lfey76zwCI5+XY+gFQlYYy8mxRKLy/jRZJLrJBS7FgE3BAjA kRrA== In-Reply-To: <20140103.003404.1439874071277993396.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Content-Type: text/plain; charset="us-ascii"; format="flowed" To: clbchenlibo.chen-hv44wF8Li93QT0dZR+AlfA@public.gmane.org Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jasowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kaber-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org, edumazet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org, ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, David Miller , xemul-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org On 01/02/2014 09:34 PM, David Miller wrote: > From: Libo Chen > Date: Fri, 3 Jan 2014 11:11:04 +0800 > >> >> introduce backup_classid to struct skbuff, >> we can use it to backup sk_classid when net_ns switch. >> >> Signed-off-by: Libo Chen > > Sorry, no new sk_buff members unless there is absolutely not other > possible implementation. > > sk_buff is too big as-is. To get what you want fix the dev_forward_skb() call. But its not clear to me why you would expect the sock info to be propagated like this. It seems like an incorrect assumption or a misunderstanding somewhere. If the virtual link was a physical link you wouldn't expect to know anything about the senders socket. Thanks, John -- John Fastabend Intel Corporation From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751466AbaACGWL (ORCPT ); Fri, 3 Jan 2014 01:22:11 -0500 Received: from mail-oa0-f41.google.com ([209.85.219.41]:34231 "EHLO mail-oa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751014AbaACGWJ (ORCPT ); Fri, 3 Jan 2014 01:22:09 -0500 Message-ID: <52C656F2.8060803@gmail.com> Date: Thu, 02 Jan 2014 22:21:38 -0800 From: John Fastabend User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: clbchenlibo.chen@huawei.com CC: David Miller , edumazet@google.com, jasowang@redhat.com, horms@verge.net.au, serge.hallyn@ubuntu.com, netdev@vger.kernel.org, cgroups@vger.kernel.org, containers@lists.linux-foundation.org, kaber@trash.net, xemul@openvz.org, ebiederm@xmission.com, linux-kernel@vger.kernel.org, jhs@mojatatu.com, lizefan@huawei.com Subject: Re: [RFC PATCH net-next 1/4] net: introduce backup_classid to struct skbuff References: <52C62A48.1050604@huawei.com> <20140103.003404.1439874071277993396.davem@davemloft.net> In-Reply-To: <20140103.003404.1439874071277993396.davem@davemloft.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/02/2014 09:34 PM, David Miller wrote: > From: Libo Chen > Date: Fri, 3 Jan 2014 11:11:04 +0800 > >> >> introduce backup_classid to struct skbuff, >> we can use it to backup sk_classid when net_ns switch. >> >> Signed-off-by: Libo Chen > > Sorry, no new sk_buff members unless there is absolutely not other > possible implementation. > > sk_buff is too big as-is. To get what you want fix the dev_forward_skb() call. But its not clear to me why you would expect the sock info to be propagated like this. It seems like an incorrect assumption or a misunderstanding somewhere. If the virtual link was a physical link you wouldn't expect to know anything about the senders socket. Thanks, John -- John Fastabend Intel Corporation