From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] ARM: shmobile: Koelsch: Add QSPI support
Date: Fri, 03 Jan 2014 15:51:50 +0000 [thread overview]
Message-ID: <52C6EAA7.7050200@cogentembedded.com> (raw)
In-Reply-To: <1388763256-25851-4-git-send-email-geert@linux-m68k.org>
Hello.
On 01/03/2014 06:34 PM, Geert Uytterhoeven wrote:
> From: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
> Enable support for the Spansion s25fl512s SPI FLASH on the Koelsch board:
> - Add QSPI platform device, resources, platform data, and pinmux,
> - Add FLASH data and MTD partitions.
> Signed-off-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
> ---
> arch/arm/mach-shmobile/board-koelsch.c | 61 ++++++++++++++++++++++++++++++++
> 1 file changed, 61 insertions(+)
> diff --git a/arch/arm/mach-shmobile/board-koelsch.c b/arch/arm/mach-shmobile/board-koelsch.c
> index de7cc64b1f37..723ed54b38be 100644
> --- a/arch/arm/mach-shmobile/board-koelsch.c
> +++ b/arch/arm/mach-shmobile/board-koelsch.c
[...]
> @@ -190,6 +246,11 @@ static void __init koelsch_add_standard_devices(void)
> platform_device_register_data(&platform_bus, "gpio-keys", -1,
> &koelsch_keys_pdata,
> sizeof(koelsch_keys_pdata));
> + platform_device_register_resndata(&platform_bus, "qspi", 0,
As I understood, there's single QSPI controller, so why you pass 0, and
not -1 here?
> + qspi_resources,
> + ARRAY_SIZE(qspi_resources),
> + &qspi_pdata, sizeof(qspi_pdata));
> + spi_register_board_info(spi_info, ARRAY_SIZE(spi_info));
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: shmobile: Koelsch: Add QSPI support
Date: Fri, 03 Jan 2014 19:51:51 +0300 [thread overview]
Message-ID: <52C6EAA7.7050200@cogentembedded.com> (raw)
In-Reply-To: <1388763256-25851-4-git-send-email-geert@linux-m68k.org>
Hello.
On 01/03/2014 06:34 PM, Geert Uytterhoeven wrote:
> From: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
> Enable support for the Spansion s25fl512s SPI FLASH on the Koelsch board:
> - Add QSPI platform device, resources, platform data, and pinmux,
> - Add FLASH data and MTD partitions.
> Signed-off-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
> ---
> arch/arm/mach-shmobile/board-koelsch.c | 61 ++++++++++++++++++++++++++++++++
> 1 file changed, 61 insertions(+)
> diff --git a/arch/arm/mach-shmobile/board-koelsch.c b/arch/arm/mach-shmobile/board-koelsch.c
> index de7cc64b1f37..723ed54b38be 100644
> --- a/arch/arm/mach-shmobile/board-koelsch.c
> +++ b/arch/arm/mach-shmobile/board-koelsch.c
[...]
> @@ -190,6 +246,11 @@ static void __init koelsch_add_standard_devices(void)
> platform_device_register_data(&platform_bus, "gpio-keys", -1,
> &koelsch_keys_pdata,
> sizeof(koelsch_keys_pdata));
> + platform_device_register_resndata(&platform_bus, "qspi", 0,
As I understood, there's single QSPI controller, so why you pass 0, and
not -1 here?
> + qspi_resources,
> + ARRAY_SIZE(qspi_resources),
> + &qspi_pdata, sizeof(qspi_pdata));
> + spi_register_board_info(spi_info, ARRAY_SIZE(spi_info));
WBR, Sergei
next prev parent reply other threads:[~2014-01-03 15:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-03 15:34 [PATCH 0/3] Add QSPI support on r8a7791/koelsch Geert Uytterhoeven
2014-01-03 15:34 ` Geert Uytterhoeven
2014-01-03 15:34 ` [PATCH 1/3] pinctrl: sh-pfc: r8a7791: Add QSPI pin groups Geert Uytterhoeven
2014-01-03 15:34 ` Geert Uytterhoeven
2014-01-07 14:58 ` Laurent Pinchart
2014-01-07 14:58 ` Laurent Pinchart
2014-01-07 19:53 ` Geert Uytterhoeven
2014-01-07 19:53 ` Geert Uytterhoeven
2014-01-03 15:34 ` [PATCH 2/3] ARM: shmobile: r8a7791: add QSPI clock Geert Uytterhoeven
2014-01-03 15:34 ` Geert Uytterhoeven
2014-01-03 15:34 ` [PATCH 3/3] ARM: shmobile: Koelsch: Add QSPI support Geert Uytterhoeven
2014-01-03 15:34 ` Geert Uytterhoeven
2014-01-03 15:51 ` Sergei Shtylyov [this message]
2014-01-03 16:51 ` Sergei Shtylyov
2014-01-03 16:07 ` Geert Uytterhoeven
2014-01-03 16:07 ` Geert Uytterhoeven
2014-01-06 0:39 ` Kuninori Morimoto
2014-01-06 0:39 ` Kuninori Morimoto
2014-01-06 2:24 ` Simon Horman
2014-01-06 2:24 ` Simon Horman
2014-01-07 1:20 ` [PATCH 0/3] Add QSPI support on r8a7791/koelsch Simon Horman
2014-01-07 1:20 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52C6EAA7.7050200@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.