All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Perevalov <a.perevalov@samsung.com>
To: John Stultz <john.stultz@linaro.org>
Cc: linux-kernel@vger.kernel.org, anton@enomsg.org,
	kyungmin.park@samsung.com, akpm@linux-foundation.org
Subject: Re: [PATCH 0/3] Deferrable timers support for timerfd API
Date: Fri, 03 Jan 2014 21:45:06 +0400	[thread overview]
Message-ID: <52C6F722.3090704@samsung.com> (raw)
In-Reply-To: <52C5F38D.5060201@linaro.org>

On 01/03/2014 03:17 AM, John Stultz wrote:
> On 01/02/2014 10:30 AM, Alexey Perevalov wrote:
>> This version introduces new clockid (CLOCK_DEFERRABLE) , for timerfd_create, instead of
>> new flag (TFD_TIMER_DEFERRABLE) for timerfd_settime introduced in previous version.
> So why did you make this change?
>
> thanks
> -john
>
>

I looked at alarm timers and found approach of making timer behavior 
persistent per file descriptor is better than
changeable by timerfd_settime. I think "end user wake up from suspend" 
and "don't wake up in idle" is the same thing on the same abstraction level.

Yes Anton's previous  patches worked with CLOCK_MONOTONIC only and I 
didn't intend to use it with CLOCK_REALTIME, cause it's hard to me to 
find such use case.
Another way - it's stay as was Anton's patch, I mean as flag for the 
timerfd_settime, but in original patch set both hrtimer and deferrable 
timers initialized in timerfd_create, I think it's not needed. Also 
ability to change timer behavior looks not good if you couldn't change 
alarm timer behavior, not unified API.

If I'm right, only high resolution timer could be REALTIME, and there is 
no deferrable behavior for hrtimer only for timer_list.


-- 
Best regards,
Alexey Perevalov

  reply	other threads:[~2014-01-03 17:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-02 18:30 [PATCH 0/3] Deferrable timers support for timerfd API Alexey Perevalov
2014-01-02 18:30 ` [PATCH 1/3] kernel/time: Add new helpers to convert ktime to/from jiffies Alexey Perevalov
2014-01-02 18:30 ` [PATCH 2/3] timerfd: Factor out timer-type unspecific timerfd_expire() Alexey Perevalov
2014-01-02 18:30 ` [PATCH 3/3] timerfd: Add support for deferrable timers Alexey Perevalov
2014-01-02 19:32   ` John Stultz
2014-01-02 23:17 ` [PATCH 0/3] Deferrable timers support for timerfd API John Stultz
2014-01-03 17:45   ` Alexey Perevalov [this message]
2014-01-04  0:18     ` John Stultz
2014-01-05 19:33       ` Alexey Perevalov
2014-01-09 20:32         ` John Stultz
2014-01-12 17:16           ` Alexey Perevalov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52C6F722.3090704@samsung.com \
    --to=a.perevalov@samsung.com \
    --cc=akpm@linux-foundation.org \
    --cc=anton@enomsg.org \
    --cc=john.stultz@linaro.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.