From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Kiszka <jan.kiszka@web.de>
Subject: Re: nested_free_all_saved_vmcss freeing vmx->vmcs01?
Date: Fri, 03 Jan 2014 20:53:06 +0100
Message-ID: <52C71522.7060802@web.de>
References: <20140103190217.GB16151@amt.cnet>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="51hwbc59St6g01nk8IBaoMUrrNAjwWG1T"
To: Marcelo Tosatti <mtosatti@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	kvm-devel <kvm@vger.kernel.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mout.web.de ([212.227.15.3]:49545 "EHLO mout.web.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753187AbaACTxK (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 3 Jan 2014 14:53:10 -0500
Received: from mchn199C.mchp.siemens.de ([95.157.58.223]) by smtp.web.de
 (mrweb103) with ESMTPSA (Nemesis) id 0Mgwhg-1Vm1fo2WvI-00M5NB for
 <kvm@vger.kernel.org>; Fri, 03 Jan 2014 20:53:08 +0100
In-Reply-To: <20140103190217.GB16151@amt.cnet>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--51hwbc59St6g01nk8IBaoMUrrNAjwWG1T
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On 2014-01-03 20:02, Marcelo Tosatti wrote:
>=20
> Am i missing something, or should nested_free_all_saved_vmcss not
> call=20
>=20
>         if (vmx->loaded_vmcs !=3D &vmx->vmcs01)
>                 free_loaded_vmcs(&vmx->vmcs01);
>=20
> ?

This is relevant if we call nested_free_all_saved_vmcss on cleanup while
L2 was still active. In this case, the
free_loaded_vmcs(vmx->loaded_vmcs) will free the item's loaded_vmcs we
skipped earlier in that function - OK, and now I also understand your pat=
ch.

Jan



--51hwbc59St6g01nk8IBaoMUrrNAjwWG1T
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlLHFSIACgkQitSsb3rl5xQQvwCdEy5mg3ESSTq3R8tLQkpsdPfN
BSkAoN7aF4kEzdFIKRO0YRcKU9fbhABa
=vOUU
-----END PGP SIGNATURE-----

--51hwbc59St6g01nk8IBaoMUrrNAjwWG1T--