From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp-vbr9.xs4all.nl ([194.109.24.29]:1477 "EHLO smtp-vbr9.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750881AbaAEMFS (ORCPT ); Sun, 5 Jan 2014 07:05:18 -0500 Message-ID: <52C94A64.2050300@xs4all.nl> Date: Sun, 05 Jan 2014 13:04:52 +0100 From: Hans Verkuil MIME-Version: 1.0 To: Antti Palosaari CC: linux-media@vger.kernel.org, Mauro Carvalho Chehab Subject: Re: [PATCH RFC v6 10/12] DocBook: document 1 Hz flag References: <1388289844-2766-1-git-send-email-crope@iki.fi> <1388289844-2766-11-git-send-email-crope@iki.fi> In-Reply-To: <1388289844-2766-11-git-send-email-crope@iki.fi> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: More small fixes: On 12/29/2013 05:04 AM, Antti Palosaari wrote: > Update documention to reflect 1 Hz frequency step flag. documention -> documentation > > Cc: Hans Verkuil > Signed-off-by: Antti Palosaari > --- > .../DocBook/media/v4l/vidioc-enum-freq-bands.xml | 8 +++++--- > Documentation/DocBook/media/v4l/vidioc-g-frequency.xml | 5 +++-- > Documentation/DocBook/media/v4l/vidioc-g-modulator.xml | 6 ++++-- > Documentation/DocBook/media/v4l/vidioc-g-tuner.xml | 15 ++++++++++++--- > Documentation/DocBook/media/v4l/vidioc-s-hw-freq-seek.xml | 8 ++++++-- > 5 files changed, 30 insertions(+), 12 deletions(-) > > diff --git a/Documentation/DocBook/media/v4l/vidioc-enum-freq-bands.xml b/Documentation/DocBook/media/v4l/vidioc-enum-freq-bands.xml > index 6541ba0..60ad9ea 100644 > --- a/Documentation/DocBook/media/v4l/vidioc-enum-freq-bands.xml > +++ b/Documentation/DocBook/media/v4l/vidioc-enum-freq-bands.xml > @@ -100,7 +100,7 @@ See > capability > The tuner/modulator capability flags for > this frequency band, see . The V4L2_TUNER_CAP_LOW > -capability must be the same for all frequency bands of the selected tuner/modulator. > +or V4L2_TUNER_CAP_1HZ capability must be the same for all frequency bands of the selected tuner/modulator. > So either all bands have that capability set, or none of them have that capability. > > > @@ -109,7 +109,8 @@ So either all bands have that capability set, or none of them have that capabili > The lowest tunable frequency in > units of 62.5 kHz, or if the capability > flag V4L2_TUNER_CAP_LOW is set, in units of 62.5 > -Hz, for this frequency band. > +Hz, for this frequency band. 1 Hz unit is used when capability flag Change to: "Hz, for this frequency band. A 1 Hz unit is used when the capability flag" > +V4L2_TUNER_CAP_1HZ is set. > > > __u32 > @@ -117,7 +118,8 @@ Hz, for this frequency band. > The highest tunable frequency in > units of 62.5 kHz, or if the capability > flag V4L2_TUNER_CAP_LOW is set, in units of 62.5 > -Hz, for this frequency band. > +Hz, for this frequency band. 1 Hz unit is used when capability flag Change to: "Hz, for this frequency band. A 1 Hz unit is used when the capability flag" > +V4L2_TUNER_CAP_1HZ is set. > > > __u32 > diff --git a/Documentation/DocBook/media/v4l/vidioc-g-frequency.xml b/Documentation/DocBook/media/v4l/vidioc-g-frequency.xml > index c7a1c46..01870c4 100644 > --- a/Documentation/DocBook/media/v4l/vidioc-g-frequency.xml > +++ b/Documentation/DocBook/media/v4l/vidioc-g-frequency.xml > @@ -109,9 +109,10 @@ See > __u32 > frequency > Tuning frequency in units of 62.5 kHz, or if the > -&v4l2-tuner; or &v4l2-modulator; capabilities flag > +&v4l2-tuner; or &v4l2-modulator; capability flag > V4L2_TUNER_CAP_LOW is set, in units of 62.5 > -Hz. > +Hz. 1 Hz unit is used when capability flag Change to: "Hz. A 1 Hz unit is used when the capability flag" > +V4L2_TUNER_CAP_1HZ is set. > > > __u32 > diff --git a/Documentation/DocBook/media/v4l/vidioc-g-modulator.xml b/Documentation/DocBook/media/v4l/vidioc-g-modulator.xml > index 7f4ac7e..7068b59 100644 > --- a/Documentation/DocBook/media/v4l/vidioc-g-modulator.xml > +++ b/Documentation/DocBook/media/v4l/vidioc-g-modulator.xml > @@ -113,7 +113,8 @@ change for example with the current video standard. > The lowest tunable frequency in units of 62.5 > KHz, or if the capability flag > V4L2_TUNER_CAP_LOW is set, in units of 62.5 > -Hz. > +Hz, or if the capability flag > +V4L2_TUNER_CAP_1HZ is set, in units of 1 Hz. > > > __u32 > @@ -121,7 +122,8 @@ Hz. > The highest tunable frequency in units of 62.5 > KHz, or if the capability flag > V4L2_TUNER_CAP_LOW is set, in units of 62.5 > -Hz. > +Hz, or if the capability flag > +V4L2_TUNER_CAP_1HZ is set, in units of 1 Hz. > > > __u32 > diff --git a/Documentation/DocBook/media/v4l/vidioc-g-tuner.xml b/Documentation/DocBook/media/v4l/vidioc-g-tuner.xml > index 6cc8201..b0d8659 100644 > --- a/Documentation/DocBook/media/v4l/vidioc-g-tuner.xml > +++ b/Documentation/DocBook/media/v4l/vidioc-g-tuner.xml > @@ -134,7 +134,9 @@ the structure refers to a radio tuner the > The lowest tunable frequency in > units of 62.5 kHz, or if the capability > flag V4L2_TUNER_CAP_LOW is set, in units of 62.5 > -Hz. If multiple frequency bands are supported, then > +Hz, or if the capability flag > +V4L2_TUNER_CAP_1HZ is set, in units of 1 Hz. > +If multiple frequency bands are supported, then > rangelow is the lowest frequency > of all the frequency bands. > > @@ -144,7 +146,9 @@ of all the frequency bands. > The highest tunable frequency in > units of 62.5 kHz, or if the capability > flag V4L2_TUNER_CAP_LOW is set, in units of 62.5 > -Hz. If multiple frequency bands are supported, then > +Hz, or if the capability flag > +V4L2_TUNER_CAP_1HZ is set, in units of 1 Hz. > +If multiple frequency bands are supported, then > rangehigh is the highest frequency > of all the frequency bands. > > @@ -270,7 +274,7 @@ applications must set the array to zero. > V4L2_TUNER_CAP_LOW > 0x0001 > When set, tuning frequencies are expressed in units of > -62.5 Hz, otherwise in units of 62.5 kHz. > +62.5 Hz instead of 62.5 kHz. > > > V4L2_TUNER_CAP_NORM > @@ -360,6 +364,11 @@ radio tuners. > The range to search when using the hardware seek functionality > is programmable, see &VIDIOC-S-HW-FREQ-SEEK; for details. > > + > + V4L2_TUNER_CAP_1HZ > + 0x1000 > + When set, tuning frequencies are expressed in units of 1 Hz instead of 62.5 kHz. > + > > > > diff --git a/Documentation/DocBook/media/v4l/vidioc-s-hw-freq-seek.xml b/Documentation/DocBook/media/v4l/vidioc-s-hw-freq-seek.xml > index 5b379e7..a5fc4c4 100644 > --- a/Documentation/DocBook/media/v4l/vidioc-s-hw-freq-seek.xml > +++ b/Documentation/DocBook/media/v4l/vidioc-s-hw-freq-seek.xml > @@ -121,7 +121,9 @@ field and the &v4l2-tuner; index field. > If non-zero, the lowest tunable frequency of the band to > search in units of 62.5 kHz, or if the &v4l2-tuner; > capability field has the > -V4L2_TUNER_CAP_LOW flag set, in units of 62.5 Hz. > +V4L2_TUNER_CAP_LOW flag set, in units of 62.5 Hz or if the &v4l2-tuner; > +capability field has the > +V4L2_TUNER_CAP_1HZ flag set, in units of 1 Hz. > If rangelow is zero a reasonable default value > is used. > > @@ -131,7 +133,9 @@ is used. > If non-zero, the highest tunable frequency of the band to > search in units of 62.5 kHz, or if the &v4l2-tuner; > capability field has the > -V4L2_TUNER_CAP_LOW flag set, in units of 62.5 Hz. > +V4L2_TUNER_CAP_LOW flag set, in units of 62.5 Hz or if the &v4l2-tuner; > +capability field has the > +V4L2_TUNER_CAP_1HZ flag set, in units of 1 Hz. > If rangehigh is zero a reasonable default value > is used. > > After making these minor changes you can add my: Acked-by: Hans Verkuil Regards, Hans