From: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
To: Pavel Machek <pavel@ucw.cz>,
Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
Cc: tomi.valkeinen@ti.com, plagnioj@jcrosoft.com,
pali.rohar@gmail.com, linux-omap@vger.kernel.org,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Ivaylo Dimitrov <freemangordon@abv.bg>
Subject: Re: [PATCH] ARM: OMAPFB: panel-sony-acx565akm: fix missing mutex unlocks
Date: Sun, 05 Jan 2014 12:58:17 +0000 [thread overview]
Message-ID: <52C956E9.2030008@gmail.com> (raw)
In-Reply-To: <20140104125108.GA22339@amd.pavel.ucw.cz>
On 04.01.2014 14:51, Pavel Machek wrote:
> On Mon 2013-12-30 18:17:52, Ivaylo Dimitrov wrote:
>> From: Ivaylo Dimitrov <freemangordon@abv.bg>
>>
>> Commit c37dd677988ca50bc8bc60ab5ab053720583c168 fixes the unbalanced
>> unlock in acx565akm_enable but introduces another problem - if
>> acx565akm_panel_power_on exits early, the mutex is not unlocked. Fix
>> that by unlocking the mutex on early return. Also add mutex protection in
>> acx565akm_panel_power_off and remove an unused variable
>>
>> Signed-off-by: Ivaylo Dimitrov <freemangordon@abv.bg>
> Reviewed-by: Pavel Machek <pavel@ucw.cz>
Hmm, I introduced a bug with that patch (recursive lock), will send a
new version that fixes it
Regards,
Ivo
WARNING: multiple messages have this Message-ID (diff)
From: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
To: Pavel Machek <pavel@ucw.cz>,
Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
Cc: tomi.valkeinen@ti.com, plagnioj@jcrosoft.com,
pali.rohar@gmail.com, linux-omap@vger.kernel.org,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Ivaylo Dimitrov <freemangordon@abv.bg>
Subject: Re: [PATCH] ARM: OMAPFB: panel-sony-acx565akm: fix missing mutex unlocks
Date: Sun, 05 Jan 2014 14:58:17 +0200 [thread overview]
Message-ID: <52C956E9.2030008@gmail.com> (raw)
In-Reply-To: <20140104125108.GA22339@amd.pavel.ucw.cz>
On 04.01.2014 14:51, Pavel Machek wrote:
> On Mon 2013-12-30 18:17:52, Ivaylo Dimitrov wrote:
>> From: Ivaylo Dimitrov <freemangordon@abv.bg>
>>
>> Commit c37dd677988ca50bc8bc60ab5ab053720583c168 fixes the unbalanced
>> unlock in acx565akm_enable but introduces another problem - if
>> acx565akm_panel_power_on exits early, the mutex is not unlocked. Fix
>> that by unlocking the mutex on early return. Also add mutex protection in
>> acx565akm_panel_power_off and remove an unused variable
>>
>> Signed-off-by: Ivaylo Dimitrov <freemangordon@abv.bg>
> Reviewed-by: Pavel Machek <pavel@ucw.cz>
Hmm, I introduced a bug with that patch (recursive lock), will send a
new version that fixes it
Regards,
Ivo
next prev parent reply other threads:[~2014-01-05 12:58 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 21:24 [PATCH] ARM: OMAPFB: panel-sony-acx565akm: fix bad unlock balance Aaro Koskinen
2013-11-06 21:24 ` Aaro Koskinen
2013-11-11 13:37 ` Tomi Valkeinen
2013-11-11 13:37 ` Tomi Valkeinen
2013-11-11 18:37 ` Aaro Koskinen
2013-11-11 18:37 ` Aaro Koskinen
2013-12-06 12:55 ` [PATCH] ARM: OMAPFB: panel-sony-acx565akm: fix missing unlock in acx565akm_panel_power_on() Wei Yongjun
2013-12-06 12:55 ` Wei Yongjun
2013-12-11 14:29 ` Tomi Valkeinen
2013-12-11 14:29 ` Tomi Valkeinen
2013-12-30 16:17 ` [PATCH] ARM: OMAPFB: panel-sony-acx565akm: fix missing mutex unlocks Ivaylo Dimitrov
2013-12-30 16:17 ` Ivaylo Dimitrov
2014-01-04 12:51 ` Pavel Machek
2014-01-04 12:51 ` Pavel Machek
2014-01-05 12:58 ` Ivaylo Dimitrov [this message]
2014-01-05 12:58 ` Ivaylo Dimitrov
2014-01-05 13:13 ` [PATCH v2] " Ivaylo Dimitrov
2014-01-05 13:13 ` Ivaylo Dimitrov
2014-01-10 10:56 ` Tomi Valkeinen
2014-01-10 10:56 ` Tomi Valkeinen
2014-01-10 10:56 ` Tomi Valkeinen
2014-01-11 9:39 ` Ivaylo Dimitrov
2014-01-11 9:39 ` Ivaylo Dimitrov
2014-01-13 10:20 ` Tomi Valkeinen
2014-01-13 10:20 ` Tomi Valkeinen
2014-01-13 10:20 ` Tomi Valkeinen
2015-12-25 13:29 ` Ivaylo Dimitrov
2015-12-25 13:29 ` Ivaylo Dimitrov
2015-12-29 7:46 ` Tomi Valkeinen
2015-12-29 7:46 ` Tomi Valkeinen
2015-12-29 7:46 ` Tomi Valkeinen
2016-01-01 12:25 ` Ivaylo Dimitrov
2016-01-01 12:25 ` Ivaylo Dimitrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52C956E9.2030008@gmail.com \
--to=ivo.g.dimitrov.75@gmail.com \
--cc=freemangordon@abv.bg \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=plagnioj@jcrosoft.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.