From: Lars-Peter Clausen <lars@metafoo.de>
To: Hartmut Knaack <knaack.h@gmx.de>
Cc: linux-iio@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH V2 1/2]staging:iio:ad799x fix error_free_irq, use devm_request_threaded_irq
Date: Sun, 05 Jan 2014 17:03:08 +0100 [thread overview]
Message-ID: <52C9823C.6030606@metafoo.de> (raw)
In-Reply-To: <52C49F06.3010505@gmx.de>
On 01/02/2014 12:04 AM, Hartmut Knaack wrote:
> Only free an IRQ in error_free_irq, if it has been requested previously.
>
> Signed-off-by: Hartmut Knaack <knaack.h@gmx.de>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
> diff --git a/drivers/staging/iio/adc/ad799x_core.c b/drivers/staging/iio/adc/ad799x_core.c
> index e32a555..3deb390 100644
> --- a/drivers/staging/iio/adc/ad799x_core.c
> +++ b/drivers/staging/iio/adc/ad799x_core.c
> @@ -590,7 +590,8 @@ static int ad799x_probe(struct i2c_client *client,
> return 0;
>
> error_free_irq:
> - free_irq(client->irq, indio_dev);
> + if (client->irq > 0)
> + free_irq(client->irq, indio_dev);
> error_cleanup_ring:
> ad799x_ring_cleanup(indio_dev);
> error_disable_reg:
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2014-01-05 16:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-01 23:04 [PATCH V2 1/2]staging:iio:ad799x fix error_free_irq, use devm_request_threaded_irq Hartmut Knaack
2014-01-05 16:03 ` Lars-Peter Clausen [this message]
2014-01-11 11:49 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52C9823C.6030606@metafoo.de \
--to=lars@metafoo.de \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.