From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH] enable/disable dom0_11_mapping from command-line and default to enabled Date: Sun, 05 Jan 2014 20:15:49 +0000 Message-ID: <52C9BD75.6070207@linaro.org> References: <1388949703-1091-1-git-send-email-karim.allah.ahmed@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini , Karim Raslan Cc: Ian Campbell , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 01/05/2014 07:24 PM, Stefano Stabellini wrote: > On Sun, 5 Jan 2014, Karim Raslan wrote: >> Signed-off-by: Karim Raslan > > Thanks! > Given that dom0_11_mapping is an int, the patch is OK. > However it might be better to turn dom0_11_mapping into a bool_t and use > boolean_param instead. After reading the thread "Master not working on AllWinner A20", I still don't see why this patch is useful. Unless if the platform has an IOMMU, the 1:1 mapping for the memory SHOULD be enabled. Otherwise DMA-capable won't work. See my answer on your mail (thread "Master not working on AllWinner for A20") for a proper fix. -- Julien Grall