From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34886)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lig.fnst@cn.fujitsu.com>) id 1VzyTi-00080l-FY
	for qemu-devel@nongnu.org; Sun, 05 Jan 2014 19:55:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lig.fnst@cn.fujitsu.com>) id 1VzyTU-0003Ix-C4
	for qemu-devel@nongnu.org; Sun, 05 Jan 2014 19:55:38 -0500
Received: from [222.73.24.84] (port=10604 helo=song.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lig.fnst@cn.fujitsu.com>) id 1VzyTU-0003IU-0N
	for qemu-devel@nongnu.org; Sun, 05 Jan 2014 19:55:24 -0500
Message-ID: <52C9FE6B.4050408@cn.fujitsu.com>
Date: Mon, 06 Jan 2014 08:52:59 +0800
From: Li Guang <lig.fnst@cn.fujitsu.com>
MIME-Version: 1.0
References: <1388640940-12782-1-git-send-email-lig.fnst@cn.fujitsu.com>
	<CAEgOgz6_RFp6PPB8KZSLkVBe8XKAB3J1FDeR9rngCFQqOns=aw@mail.gmail.com>
	<52C52170.1040904@redhat.com>
	<CAEgOgz6jNzc8A1k6S6LXEj5V=tkmsSRjjrqKXELDxkLvog5Z8Q@mail.gmail.com>
	<52C5588B.30804@redhat.com>
In-Reply-To: <52C5588B.30804@redhat.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Subject: Re: [Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob
	loader
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Peter Crosthwaite <peter.crosthwaite@xilinx.com>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>

Paolo Bonzini wrote:
> Il 02/01/2014 11:51, Peter Crosthwaite ha scritto:
>    
>>>> No, please use "realize" and avoid init.  This way you can use an Error*
>>>> to report the error.
>>>>
>>>> Also, the actual load_image_targphys call probably should be done in a
>>>> reset handler, not at realize time.
>>>>
>>>>          
>> Ok I think that settles it. The actual blobbing needs to happen at
>> reset time. Perhaps the correct approach is to do as much as possible
>> (file-path / address sanitsation etc) at realize time, then only the
>> actual blob load happens at reset. Going on what Paolo said, I think
>> for this device ::init is actually a nop.
>>      
> Yeah, also because init is in fact a legacy interface to realize.
>
> Paolo
>
>    
Ok, thanks!