All of lore.kernel.org
 help / color / mirror / Atom feed
From: jhuang0 <jackie.huang@windriver.com>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] guile: fix the depends for target recipes
Date: Mon, 6 Jan 2014 10:24:08 +0800	[thread overview]
Message-ID: <52CA13C8.5070100@windriver.com> (raw)
In-Reply-To: <20140103101548.GB3707@jama>



On 1/3/2014 6:15 PM, Martin Jansa wrote:
> On Fri, Jan 03, 2014 at 05:37:32PM +0800, jackie.huang@windriver.com wrote:
>> From: Jackie Huang <jackie.huang@windriver.com>
>>
>> The depenency on guild-native and libatomics-ops is missing
>> in multilib build, fix the depends with class-target.
>>
>> Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
>> ---
>>   meta/recipes-devtools/guile/guile_2.0.9.bb |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-devtools/guile/guile_2.0.9.bb b/meta/recipes-devtools/guile/guile_2.0.9.bb
>> index 4c3fe28..cb7c72e 100644
>> --- a/meta/recipes-devtools/guile/guile_2.0.9.bb
>> +++ b/meta/recipes-devtools/guile/guile_2.0.9.bb
>> @@ -33,7 +33,7 @@ BBCLASSEXTEND = "native"
>>
>>   DEPENDS = "libunistring bdwgc gmp libtool libffi"
>>   # add guile-native only to the target recipe's DEPENDS
>> -DEPENDS += "${@['guile-native libatomics-ops', ''][d.getVar('PN', True) != 'guile']}"
>> +DEPENDS_append_class-target += "guile-native libatomics-ops"
>
> Don't use _append together with +=, just add space before guile-native.

Fixed and sent v2 for this, thanks!

Thanks,
Jackie

>
>>
>>   RDEPENDS_${PN}_append_libc-glibc_class-target = "glibc-gconv-iso8859-1"
>>
>> --
>> 1.7.9.5
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

-- 
Jackie Huang
WIND RIVER | China Development Center
MSN:jackielily@hotmail.com
Tel: +86 8477 8594
Mobile: +86 138 1027 4745


      reply	other threads:[~2014-01-06  2:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-03  9:37 [PATCH] guile: fix the depends for target recipes jackie.huang
2014-01-03 10:15 ` Martin Jansa
2014-01-06  2:24   ` jhuang0 [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52CA13C8.5070100@windriver.com \
    --to=jackie.huang@windriver.com \
    --cc=martin.jansa@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.