From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37126)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1W057e-0007Z5-WB
	for qemu-devel@nongnu.org; Mon, 06 Jan 2014 03:01:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pl@kamp.de>) id 1W057W-000256-JX
	for qemu-devel@nongnu.org; Mon, 06 Jan 2014 03:01:18 -0500
Received: from mx.ipv6.kamp.de ([2a02:248:0:51::16]:47103 helo=mx01.kamp.de)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1W057W-00024x-7Q
	for qemu-devel@nongnu.org; Mon, 06 Jan 2014 03:01:10 -0500
Message-ID: <52CA631B.5040005@kamp.de>
Date: Mon, 06 Jan 2014 09:02:35 +0100
From: Peter Lieven <pl@kamp.de>
MIME-Version: 1.0
References: <1388944951-14767-1-git-send-email-pl@kamp.de>
	<1388944951-14767-2-git-send-email-pl@kamp.de>
	<52CA52B6.5070202@linux.vnet.ibm.com>
In-Reply-To: <52CA52B6.5070202@linux.vnet.ibm.com>
Content-Type: text/plain; charset=GB2312
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCHv3 1/6] ui/vnc:
 introduce	VNC_DIRTY_PIXELS_PER_BIT macro
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Cc: sw@weilnetz.de, aliguori@amazon.com

On 06.01.2014 07:52, Wenchao Xia wrote:
>> @@ -781,10 +784,10 @@ static void vnc_dpy_copy(DisplayChangeListener *dcl,
>>                   if ((s = w - w_lim) == 0)
>>                       break;
>>               } else if (!x) {
>> -                s = (16 - (dst_x % 16));
>> +                s = (16 - (dst_x % VNC_DIRTY_PIXELS_PER_BIT));
> Should it be
> s = (VNC_DIRTY_PIXELS_PER_BIT - (dst_x % VNC_DIRTY_PIXELS_PER_BIT));
> ?
>

Thanks, you are right.

Peter