From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Wolfgang Grandegger <wg@grandegger.com>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: can: Disable broken flexcan driver build for big endian CPU on ARM
Date: Mon, 06 Jan 2014 10:00:35 +0100 [thread overview]
Message-ID: <52CA70B3.5020004@pengutronix.de> (raw)
In-Reply-To: <1388944283-29990-1-git-send-email-linux@roeck-us.net>
[-- Attachment #1: Type: text/plain, Size: 1624 bytes --]
On 01/05/2014 06:51 PM, Guenter Roeck wrote:
> Building arm:allmodconfig fails with
>
> flexcan.c: In function 'flexcan_read':
> flexcan.c:243:2: error: implicit declaration of function 'in_be32'
> flexcan.c: In function 'flexcan_write':
> flexcan.c:248:2: error: implicit declaration of function 'out_be32'
>
> in_be32 and out_be32 do not (or no longer) exist for ARM targets.
> Mark the build for arm on big endian CPUs as broken.
I think there isn't any ARM with this CAN core that supports BE (at
least on Linux).
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> If there is a better solution, please let me know and I'll be happy
> to provide a patch.
>
> drivers/net/can/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig
> index 3c06947..8d202f4 100644
> --- a/drivers/net/can/Kconfig
> +++ b/drivers/net/can/Kconfig
> @@ -104,7 +104,7 @@ config CAN_JANZ_ICAN3
>
> config CAN_FLEXCAN
> tristate "Support for Freescale FLEXCAN based chips"
> - depends on ARM || PPC
> + depends on (ARM || PPC) && (BROKEN || !ARM || CPU_LITTLE_ENDIAN)
Why not make it:
depends on (ARM && CPU_LITTLE_ENDIAN) || PPC
> ---help---
> Say Y here if you want to support for Freescale FlexCAN.
>
>
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
prev parent reply other threads:[~2014-01-06 9:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-05 17:51 [PATCH] net: can: Disable broken flexcan driver build for big endian CPU on ARM Guenter Roeck
2014-01-06 9:00 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CA70B3.5020004@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=netdev@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.