From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH 15/85] drivers: gpu: Mark function as static in ctxnvd7.c Date: Mon, 06 Jan 2014 16:14:07 +0100 Message-ID: <52CAC83F.3090903@canonical.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by gabe.freedesktop.org (Postfix) with ESMTP id 455D3106085 for ; Mon, 6 Jan 2014 07:14:38 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Rashika Kheria , linux-kernel@vger.kernel.org Cc: Ben Skeggs , dri-devel@lists.freedesktop.org, josh@joshtriplett.org List-Id: dri-devel@lists.freedesktop.org b3AgMDYtMDEtMTQgMTY6MTEsIFJhc2hpa2EgS2hlcmlhIHNjaHJlZWY6Cj4gTWFyayBmdW5jdGlv biBudmQ3X2dyY3R4X2dlbmVyYXRlX21haW4oKSBhcyBzdGF0aWMgaW4KPiBkcm0vbm91dmVhdS9j b3JlL2VuZ2luZS9ncmFwaC9jdHhudmQ3LmMgYmVjYXVzZSBpdCBpcyBub3QgdXNlZCBvdXRzaWRl Cj4gdGhpcyBmaWxlLgo+Cj4gVGhpcyBlbGltaW5hdGVzIHRoZSBmb2xsb3dpbmcgd2FybmluZyBp bgo+IGRybS9ub3V2ZWF1L2NvcmUvZW5naW5lL2dyYXBoL2N0eG52ZDcuYzoKPiBkcml2ZXJzL2dw dS9kcm0vbm91dmVhdS9jb3JlL2VuZ2luZS9ncmFwaC9jdHhudmQ3LmM6MjE1OjE6IHdhcm5pbmc6 IG5vIHByZXZpb3VzIHByb3RvdHlwZSBmb3Ig4oCYbnZkN19ncmN0eF9nZW5lcmF0ZV9tYWlu4oCZ IFstV21pc3NpbmctcHJvdG90eXBlc10KPgo+IFNpZ25lZC1vZmYtYnk6IFJhc2hpa2EgS2hlcmlh IDxyYXNoaWthLmtoZXJpYUBnbWFpbC5jb20+Cj4gUmV2aWV3ZWQtYnk6IEpvc2ggVHJpcGxldHQg PGpvc2hAam9zaHRyaXBsZXR0Lm9yZz4KPiAtLS0KPiAgLi4uL2dwdS9kcm0vbm91dmVhdS9jb3Jl L2VuZ2luZS9ncmFwaC9jdHhudmQ3LmMgICAgfCAgICAyICstCj4gIDEgZmlsZSBjaGFuZ2VkLCAx IGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9ub3V2ZWF1L2NvcmUvZW5naW5lL2dyYXBoL2N0eG52ZDcuYyBiL2RyaXZlcnMvZ3B1L2Ry bS9ub3V2ZWF1L2NvcmUvZW5naW5lL2dyYXBoL2N0eG52ZDcuYwo+IGluZGV4IGM0NzQwZDUuLjBl MTI2Y2UgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvY29yZS9lbmdpbmUv Z3JhcGgvY3R4bnZkNy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvY29yZS9lbmdp bmUvZ3JhcGgvY3R4bnZkNy5jCj4gQEAgLTIxMSw3ICsyMTEsNyBAQCBudmQ3X2dyY3R4X2dlbmVy YXRlX21vZHMoc3RydWN0IG52YzBfZ3JhcGhfcHJpdiAqcHJpdiwgc3RydWN0IG52YzBfZ3JjdHgg KmluZm8pCj4gIAltbWlvX2xpc3QoMHgxN2U5MWMsIDB4MDMwNjA2MDksIDAsIDApOyAvKiBkaWZm ZXJlbnQgZnJvbSBrZXBsZXIgKi8KPiAgfQo+ICAKPiAtdm9pZAo+ICtzdGF0aWMgdm9pZAo+ICBu dmQ3X2dyY3R4X2dlbmVyYXRlX21haW4oc3RydWN0IG52YzBfZ3JhcGhfcHJpdiAqcHJpdiwgc3Ry dWN0IG52YzBfZ3JjdHggKmluZm8pCj4gIHsKPiAgCXN0cnVjdCBudmMwX2dyY3R4X29jbGFzcyAq b2NsYXNzID0gKHZvaWQgKiludl9lbmdpbmUocHJpdiktPmNjbGFzczsKQWNrZWQtYnk6IE1hYXJ0 ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBjYW5vbmljYWwuY29tPgoKQnVpbGRpbmcg d2l0aCAtV21pc3NpbmctcHJvdG90eXBlcz8gR29vZCBsdWNrIGZpeGluZyByYWRlb24hIGl0J3Mg YSBtZXNzLiA6KApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755006AbaAFPOj (ORCPT ); Mon, 6 Jan 2014 10:14:39 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:35072 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751262AbaAFPOh (ORCPT ); Mon, 6 Jan 2014 10:14:37 -0500 Message-ID: <52CAC83F.3090903@canonical.com> Date: Mon, 06 Jan 2014 16:14:07 +0100 From: Maarten Lankhorst User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Rashika Kheria , linux-kernel@vger.kernel.org CC: David Airlie , Ben Skeggs , dri-devel@lists.freedesktop.org, josh@joshtriplett.org Subject: Re: [PATCH 15/85] drivers: gpu: Mark function as static in ctxnvd7.c References: In-Reply-To: X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org op 06-01-14 16:11, Rashika Kheria schreef: > Mark function nvd7_grctx_generate_main() as static in > drm/nouveau/core/engine/graph/ctxnvd7.c because it is not used outside > this file. > > This eliminates the following warning in > drm/nouveau/core/engine/graph/ctxnvd7.c: > drivers/gpu/drm/nouveau/core/engine/graph/ctxnvd7.c:215:1: warning: no previous prototype for ‘nvd7_grctx_generate_main’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria > Reviewed-by: Josh Triplett > --- > .../gpu/drm/nouveau/core/engine/graph/ctxnvd7.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/nouveau/core/engine/graph/ctxnvd7.c b/drivers/gpu/drm/nouveau/core/engine/graph/ctxnvd7.c > index c4740d5..0e126ce 100644 > --- a/drivers/gpu/drm/nouveau/core/engine/graph/ctxnvd7.c > +++ b/drivers/gpu/drm/nouveau/core/engine/graph/ctxnvd7.c > @@ -211,7 +211,7 @@ nvd7_grctx_generate_mods(struct nvc0_graph_priv *priv, struct nvc0_grctx *info) > mmio_list(0x17e91c, 0x03060609, 0, 0); /* different from kepler */ > } > > -void > +static void > nvd7_grctx_generate_main(struct nvc0_graph_priv *priv, struct nvc0_grctx *info) > { > struct nvc0_grctx_oclass *oclass = (void *)nv_engine(priv)->cclass; Acked-by: Maarten Lankhorst Building with -Wmissing-prototypes? Good luck fixing radeon! it's a mess. :(