From: Saul Wold <sgw@linux.intel.com>
To: Jacob Kroon <jacob.kroon@gmail.com>,
openembedded-core@lists.openembedded.org
Subject: Re: Strange looking commit in oe-core, 4cee162c292915e
Date: Mon, 06 Jan 2014 08:15:00 -0800 [thread overview]
Message-ID: <52CAD684.9000100@linux.intel.com> (raw)
In-Reply-To: <alpine.LFD.2.11.1401061314390.9209@localhost.localdomain>
On 01/06/2014 04:25 AM, Jacob Kroon wrote:
> Hi,
>
> Just an observation from my side, I was looking at the recent commits
> in OE-Core and saw 4cee162c292915e68e8efcab68a31ba0e48105e9,
> "enchant: fix unrecognised option"
>
> The actual commit message doesn't seem to have anything to do with the
> actual patch. Perhaps it has been rebased and gone through some other
> massaging, the patch seems to make sense, at least to me, still it
> would be nice to always have sane commit messages.
>
I will take the blame for that one, not Robert's fault, this happened
when I merged and rebased a change locally and did not realize it was a
"do nothing" patch in the end, better final review on my part.
That line was moved in one of Paul's patches orignally.
Thanks for the reminder to be more watchful.
Sau!
> Regards
> Jacob
prev parent reply other threads:[~2014-01-06 16:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-06 12:25 Strange looking commit in oe-core, 4cee162c292915e Jacob Kroon
2014-01-06 13:09 ` Richard Purdie
2014-01-06 16:15 ` Saul Wold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CAD684.9000100@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=jacob.kroon@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.