From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33503) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0Euw-0007l9-Ot for qemu-devel@nongnu.org; Mon, 06 Jan 2014 13:28:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0Eus-0004Sh-1K for qemu-devel@nongnu.org; Mon, 06 Jan 2014 13:28:50 -0500 Received: from mail-qc0-x233.google.com ([2607:f8b0:400d:c01::233]:58042) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0Eur-0004Sb-QU for qemu-devel@nongnu.org; Mon, 06 Jan 2014 13:28:45 -0500 Received: by mail-qc0-f179.google.com with SMTP id i8so18285194qcq.10 for ; Mon, 06 Jan 2014 10:28:45 -0800 (PST) Sender: Richard Henderson Message-ID: <52CAF5D8.7090808@twiddle.net> Date: Mon, 06 Jan 2014 10:28:40 -0800 From: Richard Henderson MIME-Version: 1.0 References: <1389013881-15726-1-git-send-email-peter.maydell@linaro.org> <1389013881-15726-14-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1389013881-15726-14-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 13/24] softfloat: Factor out RoundAndPackFloat16 and NormalizeFloat16Subnormal List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: Tom Musta , Peter Crosthwaite , patches@linaro.org, Michael Matz , Alexander Graf , Claudio Fontana , Dirk Mueller , Will Newton , Laurent Desnogues , =?ISO-8859-1?Q?Alex_Benn=E9e?= , kvmarm@lists.cs.columbia.edu, Christoffer Dall On 01/06/2014 05:11 AM, Peter Maydell wrote: > In preparation for adding conversions between float16 and float64, > factor out code currently done inline in the float16<=>float32 > conversion functions into functions RoundAndPackFloat16 and > NormalizeFloat16Subnormal along the lines of the existing versions > for the other float types. > > Note that we change the handling of zExp from the inline code > to match the API of the other RoundAndPackFloat functions; however > we leave the positioning of the binary point between bits 22 and 23 > rather than shifting it up to the high end of the word. > > Signed-off-by: Peter Maydell > --- > fpu/softfloat.c | 209 +++++++++++++++++++++++++++++++++----------------------- > 1 file changed, 125 insertions(+), 84 deletions(-) Reviewed-by: Richard Henderson r~