From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34768)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1W0F10-0004J4-4Q
	for qemu-devel@nongnu.org; Mon, 06 Jan 2014 13:35:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1W0F0u-000601-Mi
	for qemu-devel@nongnu.org; Mon, 06 Jan 2014 13:35:06 -0500
Received: from mail-qc0-x229.google.com ([2607:f8b0:400d:c01::229]:57807)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1W0F0u-0005zt-EU
	for qemu-devel@nongnu.org; Mon, 06 Jan 2014 13:35:00 -0500
Received: by mail-qc0-f169.google.com with SMTP id r5so18169786qcx.28
	for <qemu-devel@nongnu.org>; Mon, 06 Jan 2014 10:34:59 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <52CAF74F.3040508@twiddle.net>
Date: Mon, 06 Jan 2014 10:34:55 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1389013881-15726-1-git-send-email-peter.maydell@linaro.org>
	<1389013881-15726-16-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1389013881-15726-16-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 15/24] softfloat: Refactor code handling
 various rounding modes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Tom Musta <tommusta@gmail.com>, Peter Crosthwaite <peter.crosthwaite@xilinx.com>, patches@linaro.org, Michael Matz <matz@suse.de>, Alexander Graf <agraf@suse.de>, Claudio Fontana <claudio.fontana@linaro.org>, Dirk Mueller <dmueller@suse.de>, Will Newton <will.newton@linaro.org>, Laurent Desnogues <laurent.desnogues@gmail.com>, =?ISO-8859-1?Q?Alex_Benn=E9e?= <alex.bennee@linaro.org>, kvmarm@lists.cs.columbia.edu, Christoffer Dall <christoffer.dall@linaro.org>

On 01/06/2014 05:11 AM, Peter Maydell wrote:
> Refactor the code in various functions which calculates rounding
> increments given the current rounding mode, so that instead of a
> set of nested if statements we have a simple switch statement.
> This will give us a clean place to add the case for the new
> tiesAway rounding mode.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  fpu/softfloat.c | 405 +++++++++++++++++++++++++++++++++-----------------------
>  1 file changed, 241 insertions(+), 164 deletions(-)

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~