From: Randy Dunlap <rdunlap@infradead.org>
To: Bart Van Assche <bvanassche@acm.org>,
"James E.J. Bottomley" <JBottomley@parallels.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
David Dillow <dillowda@ornl.gov>, Vu Pham <vu@mellanox.com>,
Sebastian Riemer <sebastian.riemer@profitbricks.com>,
Douglas Gilbert <dgilbert@interlog.com>
Subject: Re: [PATCH] scsi_transport_srp: Fix kernel-doc warnings
Date: Mon, 06 Jan 2014 12:26:18 -0800 [thread overview]
Message-ID: <52CB116A.8050502@infradead.org> (raw)
In-Reply-To: <52CA4F9F.20600@acm.org>
On 01/05/14 22:39, Bart Van Assche wrote:
> On 01/05/14 21:39, Randy Dunlap wrote:
>> On 01/05/14 01:13, Bart Van Assche wrote:
>>> The following command has been used to verify that the kernel-doc
>>> tool no longer complains about undocumented fields:
>>>
>>> scripts/kernel-doc -html drivers/scsi/scsi_transport_srp.c \
>>> include/scsi/scsi_transport_srp.h >srp-transport-doc.html
>>
>> Thanks for the patch.
>> I guess that your tree is different from mine. Using 3.13-rc7, I still get
>> 3 warnings:
>>
>> Warning(drivers/scsi/scsi_transport_srp.c:620): No description found for parameter 'scmd'
>> Warning(drivers/scsi/scsi_transport_srp.c:688): No description found for parameter 'rport'
>> Warning(drivers/scsi/scsi_transport_srp.c:697): No description found for parameter 'rport'
>>
>> I also had some trouble with the patch itself -- looks like some of its longer
>> lines were broken (split) by your mail app (I'm guessing).
>> The first split line is marked below.
>
> Sorry but it seems like my e-mail client line-wrapped the patch. Does
> the attached patch work better ? The attached patch should be identical
> to what I posted except for the line wrapping. I do not see the warnings
> mentioned above - maybe these were introduced by the line wrapping ?
Yes, that patch works for me. Thanks.
Acked-by: Randy Dunlap <rdunlap@infradead.org>
--
~Randy
prev parent reply other threads:[~2014-01-06 20:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-30 5:02 scsi_transport_srp.c kernel-doc warnings Randy Dunlap
2014-01-05 1:53 ` [PATCH] scsi: eliminate " Randy Dunlap
2014-01-05 9:13 ` [PATCH] scsi_transport_srp: Fix " Bart Van Assche
2014-01-05 20:39 ` Randy Dunlap
2014-01-06 6:39 ` Bart Van Assche
2014-01-06 12:53 ` Sebastian Riemer
2014-01-06 20:26 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CB116A.8050502@infradead.org \
--to=rdunlap@infradead.org \
--cc=JBottomley@parallels.com \
--cc=bvanassche@acm.org \
--cc=dgilbert@interlog.com \
--cc=dillowda@ornl.gov \
--cc=linux-scsi@vger.kernel.org \
--cc=sebastian.riemer@profitbricks.com \
--cc=vu@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.